dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 04:42:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(transformer/class-properties): safer use of GetAddress (#7474)

Browse source 
Avoid using `Address::from_ptr`, which is error-prone.
This commit is contained in:
overlookmotel 2024-11-25 14:25:27 +00:00
parent 3396b69379
commit 25823c8529
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
crates/oxc_transformer/src/es2022/class_properties/class.rs
View file

@ -1,7 +1,7 @@
//! ES2022: Class Properties //! ES2022: Class Properties
//! Transform of class itself. //! Transform of class itself.
use oxc_allocator::Address; use oxc_allocator::{Address, GetAddress};
use oxc_ast::{ast::*, NONE}; use oxc_ast::{ast::*, NONE};
use oxc_span::SPAN; use oxc_span::SPAN;
use oxc_syntax::{ use oxc_syntax::{
@ -35,7 +35,8 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
) { ) {
let Expression::ClassExpression(class) = expr else { unreachable!() }; let Expression::ClassExpression(class) = expr else { unreachable!() };
let expr_count = self.transform_class_expression_start(class, ctx); let class_address = class.address();
let expr_count = self.transform_class_expression_start(class, class_address, ctx);
if expr_count > 0 { if expr_count > 0 {
self.transform_class_expression_finish(expr, expr_count, ctx); self.transform_class_expression_finish(expr, expr_count, ctx);
} }
@ -44,10 +45,10 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
fn transform_class_expression_start( fn transform_class_expression_start(
&mut self, &mut self,
class: &mut Class<'a>, class: &mut Class<'a>,
class_address: Address,
ctx: &mut TraverseCtx<'a>, ctx: &mut TraverseCtx<'a>,
) -> usize { ) -> usize {
// Check this class isn't being visited twice // Check this class isn't being visited twice
let class_address = Address::from_ptr(class);
if *self.class_expression_addresses_stack.last() == class_address { if *self.class_expression_addresses_stack.last() == class_address {
// This class has already been transformed, and we're now encountering it again // This class has already been transformed, and we're now encountering it again
// in the sequence expression which was substituted for it. So don't transform it again! // in the sequence expression which was substituted for it. So don't transform it again!