From 24ac957660b5a315fa7d8c38b6b686b2403170fa Mon Sep 17 00:00:00 2001 From: Dunqing Date: Wed, 17 Jan 2024 16:08:31 +0800 Subject: [PATCH] fix(semantic): incorrect reference flag (#2057) --- crates/oxc_semantic/src/builder.rs | 3 ++- tasks/transform_conformance/babel.snap.md | 5 ++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/crates/oxc_semantic/src/builder.rs b/crates/oxc_semantic/src/builder.rs index fb668d9d6..b8a1e692a 100644 --- a/crates/oxc_semantic/src/builder.rs +++ b/crates/oxc_semantic/src/builder.rs @@ -478,7 +478,7 @@ impl<'a> SemanticBuilder<'a> { self.make_all_namespaces_valuelike(); self.in_type_definition = true; } - AstKind::TSTypeAnnotation(_) => { + AstKind::TSTypeParameterInstantiation(_) | AstKind::TSTypeAnnotation(_) => { self.in_type_definition = true; } AstKind::TSEnumMember(enum_member) => { @@ -553,6 +553,7 @@ impl<'a> SemanticBuilder<'a> { | AstKind::TSTypeAliasDeclaration(_) | AstKind::TSInterfaceDeclaration(_) | AstKind::TSModuleDeclaration(_) + | AstKind::TSTypeParameterInstantiation(_) | AstKind::TSTypeAnnotation(_) => { self.in_type_definition = false; } diff --git a/tasks/transform_conformance/babel.snap.md b/tasks/transform_conformance/babel.snap.md index 8099a4a57..2f2979bda 100644 --- a/tasks/transform_conformance/babel.snap.md +++ b/tasks/transform_conformance/babel.snap.md @@ -1,4 +1,4 @@ -Passed: 311/1179 +Passed: 312/1179 # All Passed: * babel-plugin-transform-numeric-separator @@ -832,7 +832,7 @@ Passed: 311/1179 * general/function-duplicate-name/input.js * general/object/input.js -# babel-plugin-transform-typescript (80/158) +# babel-plugin-transform-typescript (81/158) * class/abstract-class-decorated/input.ts * class/abstract-class-decorated-method/input.ts * class/abstract-class-decorated-parameter/input.ts @@ -857,7 +857,6 @@ Passed: 311/1179 * function/overloads-exports/input.mjs * imports/elide-injected/input.ts * imports/elide-no-import-specifiers/input.ts -* imports/elision-locations/input.ts * imports/enum-id/input.ts * imports/enum-value/input.ts * imports/import-named-type/input.ts