From 240260ea0574d9e75e48e523e988d2ebe691566b Mon Sep 17 00:00:00 2001 From: Boshen Date: Mon, 16 Oct 2023 21:11:39 +0800 Subject: [PATCH] chore(linter): update snapshots --- crates/oxc_linter/src/snapshots/ban_types.snap | 9 ++++----- .../oxc_linter/src/snapshots/no_conditional_expect.snap | 4 ++-- crates/oxc_linter/src/snapshots/no_done_callback.snap | 4 ++-- crates/oxc_linter/src/snapshots/valid_title.snap | 2 +- 4 files changed, 9 insertions(+), 10 deletions(-) diff --git a/crates/oxc_linter/src/snapshots/ban_types.snap b/crates/oxc_linter/src/snapshots/ban_types.snap index 235da9c7f..ef1d0a948 100644 --- a/crates/oxc_linter/src/snapshots/ban_types.snap +++ b/crates/oxc_linter/src/snapshots/ban_types.snap @@ -1,6 +1,5 @@ --- source: crates/oxc_linter/src/tester.rs -assertion_line: 105 expression: ban_types --- × eslint@typescript-eslint/ban-types: Do not use "String" as a type. Use "string" instead. @@ -187,7 +186,7 @@ expression: ban_types 2 │ class Test extends Foo implements Bar { 3 │ constructor(foo: String | Object | Function) {} · ────── - 4 │ + 4 │ ╰──── × eslint@typescript-eslint/ban-types: 'The `Object` type actually means "any non-nullish value", so it is marginally better than `unknown`.', @@ -198,7 +197,7 @@ expression: ban_types 2 │ class Test extends Foo implements Bar { 3 │ constructor(foo: String | Object | Function) {} · ────── - 4 │ + 4 │ ╰──── × eslint@typescript-eslint/ban-types: Don't use `Function` as a type. The `Function` type accepts any function-like value. @@ -209,7 +208,7 @@ expression: ban_types 2 │ class Test extends Foo implements Bar { 3 │ constructor(foo: String | Object | Function) {} · ──────── - 4 │ + 4 │ ╰──── × eslint@typescript-eslint/ban-types: Do not use "String" as a type. Use "string" instead. @@ -230,7 +229,7 @@ expression: ban_types × eslint@typescript-eslint/ban-types: Do not use "String" as a type. Use "string" instead. ╭─[ban_types.tsx:4:1] - 4 │ + 4 │ 5 │ arg(): Array { · ────── 6 │ const foo: String = 1 as String; diff --git a/crates/oxc_linter/src/snapshots/no_conditional_expect.snap b/crates/oxc_linter/src/snapshots/no_conditional_expect.snap index aa47181c6..cf49e9ffa 100644 --- a/crates/oxc_linter/src/snapshots/no_conditional_expect.snap +++ b/crates/oxc_linter/src/snapshots/no_conditional_expect.snap @@ -68,7 +68,7 @@ expression: no_conditional_expect ⚠ eslint(jest/no-conditional-expect): Unexpected conditional expect ╭─[no_conditional_expect.tsx:2:1] 2 │ function getValue() { - 3 │ something && expect(something).toHaveBeenCalled(); + 3 │ something && expect(something).toHaveBeenCalled(); · ──────────────────────────────────── 4 │ } ╰──── @@ -104,7 +104,7 @@ expression: no_conditional_expect ⚠ eslint(jest/no-conditional-expect): Unexpected conditional expect ╭─[no_conditional_expect.tsx:2:1] 2 │ function getValue() { - 3 │ something || expect(something).toHaveBeenCalled(); + 3 │ something || expect(something).toHaveBeenCalled(); · ──────────────────────────────────── 4 │ } ╰──── diff --git a/crates/oxc_linter/src/snapshots/no_done_callback.snap b/crates/oxc_linter/src/snapshots/no_done_callback.snap index 1805053e6..21633fbd5 100644 --- a/crates/oxc_linter/src/snapshots/no_done_callback.snap +++ b/crates/oxc_linter/src/snapshots/no_done_callback.snap @@ -201,7 +201,7 @@ expression: no_done_callback ⚠ eslint(jest/no-done-callback): "Function parameter(s) use the `done` argument" ╭─[no_done_callback.tsx:3:1] - 3 │ + 3 │ 4 │ beforeEach((done) => { · ──── 5 │ done(); @@ -210,7 +210,7 @@ expression: no_done_callback ⚠ eslint(jest/no-done-callback): "Function parameter(s) use the `done` argument" ╭─[no_done_callback.tsx:3:1] - 3 │ + 3 │ 4 │ atTheStartOfEachTest((done) => { · ──── 5 │ done(); diff --git a/crates/oxc_linter/src/snapshots/valid_title.snap b/crates/oxc_linter/src/snapshots/valid_title.snap index d5473d20a..c4825cf01 100644 --- a/crates/oxc_linter/src/snapshots/valid_title.snap +++ b/crates/oxc_linter/src/snapshots/valid_title.snap @@ -349,7 +349,7 @@ expression: valid_title ⚠ eslint(jest/valid-title): "Should not have leading or trailing spaces" ╭─[valid_title.tsx:3:1] - 3 │ + 3 │ 4 │ testThat('foo works ', () => {}); · ──────────── 5 │