dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(semantic): do not resolve references after FormalParameters in TS type (#4241)

Browse source 
Semantic resolves references when exiting `FormalParameters` to ensure references in param initializers don't get bound to bindings inside the function body.

However, it shouldn't do this for `FormalParameters` in TS types e.g. `TSTypeAnnotation` because they don't have their own scopes.
This commit is contained in:
overlookmotel 2024-07-13 02:43:01 +00:00
parent 7eb960d6e9
commit 22d56bdcac
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_semantic/src/builder.rs
View file

@ -1745,7 +1745,7 @@ impl<'a> SemanticBuilder<'a> {
self.function_stack.pop();
}
AstKind::FormalParameters(parameters) => {
if parameters.has_parameter() {
if parameters.kind != FormalParameterKind::Signature && parameters.has_parameter() {
// `function foo({bar: identifier_reference}) {}`
// ^^^^^^^^^^^^^^^^^^^^ Parameter initializer must be resolved
// after all parameters have been declared