dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(linter): shorten Option syntax (#5735)

Browse source 
Use `Some` instead of `Option::Some`.
This commit is contained in:
overlookmotel 2024-09-12 18:42:51 +00:00
parent 805fbac44c
commit 20a7861838
3 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/oxc_linter/src/rules/jsx_a11y/anchor_is_valid.rs
View file

@ -137,9 +137,7 @@ impl Rule for AnchorIsValid {
}; };
// Don't eagerly get `span` here, to avoid that work unless rule fails // Don't eagerly get `span` here, to avoid that work unless rule fails
let get_span = || jsx_el.opening_element.name.span(); let get_span = || jsx_el.opening_element.name.span();
if let Option::Some(href_attr) = if let Some(href_attr) = has_jsx_prop_ignore_case(&jsx_el.opening_element, "href") {
has_jsx_prop_ignore_case(&jsx_el.opening_element, "href")
{
let JSXAttributeItem::Attribute(attr) = href_attr else { let JSXAttributeItem::Attribute(attr) = href_attr else {
return; return;
}; };

2
crates/oxc_linter/src/rules/jsx_a11y/aria_role.rs
View file

@ -142,7 +142,7 @@ impl Rule for AriaRole {
fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) { fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
if let AstKind::JSXElement(jsx_el) = node.kind() { if let AstKind::JSXElement(jsx_el) = node.kind() {
if let Option::Some(aria_role) = has_jsx_prop(&jsx_el.opening_element, "role") { if let Some(aria_role) = has_jsx_prop(&jsx_el.opening_element, "role") {
let Some(element_type) = get_element_type(ctx, &jsx_el.opening_element) else { let Some(element_type) = get_element_type(ctx, &jsx_el.opening_element) else {
return; return;
}; };

2
crates/oxc_linter/src/rules/unicorn/catch_error_name.rs
View file

@ -75,7 +75,7 @@ impl Rule for CatchErrorName {
.unwrap_or(&vec![]) .unwrap_or(&vec![])
.iter() .iter()
.map(serde_json::Value::as_str) .map(serde_json::Value::as_str)
.filter(std::option::Option::is_some) .filter(Option::is_some)
.map(|x| CompactStr::from(x.unwrap())) .map(|x| CompactStr::from(x.unwrap()))
.collect::<Vec<CompactStr>>(); .collect::<Vec<CompactStr>>();