dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(linter): jest/prefer-hooks-in-order: improve diagnostic messages (#6036)

Browse source 
In the previous PR, I added an additional span that allows us to actually point to the prior hook function that the hook should be moved above. I've updated the error messages to hopefully be a little bit more helpful in explaining what to do.
This commit is contained in:
camchenry 2024-09-24 17:51:10 +00:00
parent c16ae6038e
commit 1f92d61097
2 changed files with 341 additions and 140 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
crates/oxc_linter/src/rules/jest/prefer_hooks_in_order.rs
View file

@ -14,9 +14,12 @@ use crate::{
}; };
fn reorder_hooks(hook: (&str, Span), previous_hook: (&str, Span)) -> OxcDiagnostic { fn reorder_hooks(hook: (&str, Span), previous_hook: (&str, Span)) -> OxcDiagnostic {
OxcDiagnostic::warn("Prefer having hooks in a consistent order.") OxcDiagnostic::warn("Test hooks are not in a consistent order.")
.with_help(format!("{:?} hooks should be before any {:?} hooks", hook.0, previous_hook.0)) .with_help(format!("{:?} hooks should be before any {:?} hooks", hook.0, previous_hook.0))
.with_label(hook.1) .with_label(
hook.1.label(format!("this should be moved to before the {:?} hook", previous_hook.0)),
)
.and_label(previous_hook.1.label(format!("{:?} hook should be called before this", hook.0)))
} }
#[derive(Debug, Default, Clone)] #[derive(Debug, Default, Clone)]

474
crates/oxc_linter/src/snapshots/prefer_hooks_in_order.snap
View file

@ -1,408 +1,606 @@
--- ---
source: crates/oxc_linter/src/tester.rs source: crates/oxc_linter/src/tester.rs
--- ---
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:6:21] ╭─[prefer_hooks_in_order.tsx:3:21]
5 │ }); 2 │ const withDatabase = () => {
3 │ ╭─▶ afterAll(() => {
4 │ │ removeMyDatabase();
5 │ ├─▶ });
· ╰──── "beforeAll" hook should be called before this
6 │ ╭─▶ beforeAll(() => { 6 │ ╭─▶ beforeAll(() => {
7 │ │ createMyDatabase(); 7 │ │ createMyDatabase();
8 │ ╰─▶ }); 8 │ ├─▶ });
· ╰──── this should be moved to before the "afterAll" hook
9 │ }; 9 │ };
╰──── ╰────
help: "beforeAll" hooks should be before any "afterAll" hooks help: "beforeAll" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:5:17] ╭─[prefer_hooks_in_order.tsx:2:17]
4 │ }); 1 │
2 │ ╭─▶ afterAll(() => {
3 │ │ removeMyDatabase();
4 │ ├─▶ });
· ╰──── "beforeAll" hook should be called before this
5 │ ╭─▶ beforeAll(() => { 5 │ ╭─▶ beforeAll(() => {
6 │ │ createMyDatabase(); 6 │ │ createMyDatabase();
7 │ ╰─▶ }); 7 │ ├─▶ });
· ╰──── this should be moved to before the "afterAll" hook
8 │ 8 │
╰──── ╰────
help: "beforeAll" hooks should be before any "afterAll" hooks help: "beforeAll" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:3:17] ╭─[prefer_hooks_in_order.tsx:2:17]
1 │
2 │ afterAll(() => {}); 2 │ afterAll(() => {});
· ─────────┬────────
· ╰── "beforeAll" hook should be called before this
3 │ beforeAll(() => {}); 3 │ beforeAll(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
4 │ 4 │
╰──── ╰────
help: "beforeAll" hooks should be before any "afterAll" hooks help: "beforeAll" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:3:17] ╭─[prefer_hooks_in_order.tsx:2:17]
1 │
2 │ afterEach(() => {}); 2 │ afterEach(() => {});
· ─────────┬─────────
· ╰── "beforeEach" hook should be called before this
3 │ beforeEach(() => {}); 3 │ beforeEach(() => {});
· ──────────────────── · ──────────┬─────────
· ╰── this should be moved to before the "afterEach" hook
4 │ 4 │
╰──── ╰────
help: "beforeEach" hooks should be before any "afterEach" hooks help: "beforeEach" hooks should be before any "afterEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:3:17] ╭─[prefer_hooks_in_order.tsx:2:17]
1 │
2 │ afterEach(() => {}); 2 │ afterEach(() => {});
· ─────────┬─────────
· ╰── "beforeAll" hook should be called before this
3 │ beforeAll(() => {}); 3 │ beforeAll(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterEach" hook
4 │ 4 │
╰──── ╰────
help: "beforeAll" hooks should be before any "afterEach" hooks help: "beforeAll" hooks should be before any "afterEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:3:17] ╭─[prefer_hooks_in_order.tsx:2:17]
1 │
2 │ beforeEach(() => {}); 2 │ beforeEach(() => {});
· ──────────┬─────────
· ╰── "beforeAll" hook should be called before this
3 │ beforeAll(() => {}); 3 │ beforeAll(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "beforeEach" hook
4 │ 4 │
╰──── ╰────
help: "beforeAll" hooks should be before any "beforeEach" hooks help: "beforeAll" hooks should be before any "beforeEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:3:17] ╭─[prefer_hooks_in_order.tsx:2:17]
1 │
2 │ afterAll(() => {}); 2 │ afterAll(() => {});
· ─────────┬────────
· ╰── "afterEach" hook should be called before this
3 │ afterEach(() => {}); 3 │ afterEach(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
4 │ 4 │
╰──── ╰────
help: "afterEach" hooks should be before any "afterAll" hooks help: "afterEach" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:5:17] ╭─[prefer_hooks_in_order.tsx:2:17]
1 │
2 │ afterAll(() => {});
· ─────────┬────────
· ╰── "afterEach" hook should be called before this
3 │ // The afterEach should do this
4 │ // This comment does not matter for the order 4 │ // This comment does not matter for the order
5 │ afterEach(() => {}); 5 │ afterEach(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
6 │ 6 │
╰──── ╰────
help: "afterEach" hooks should be before any "afterAll" hooks help: "afterEach" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:4:17] ╭─[prefer_hooks_in_order.tsx:3:17]
2 │ afterAll(() => {});
3 │ afterAll(() => {}); 3 │ afterAll(() => {});
· ─────────┬────────
· ╰── "afterEach" hook should be called before this
4 │ afterEach(() => {}); 4 │ afterEach(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
5 │ 5 │
╰──── ╰────
help: "afterEach" hooks should be before any "afterAll" hooks help: "afterEach" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:4:21] ╭─[prefer_hooks_in_order.tsx:3:21]
2 │ describe('my test', () => {
3 │ afterAll(() => {}); 3 │ afterAll(() => {});
· ─────────┬────────
· ╰── "afterEach" hook should be called before this
4 │ afterEach(() => {}); 4 │ afterEach(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
5 │ }); 5 │ });
╰──── ╰────
help: "afterEach" hooks should be before any "afterAll" hooks help: "afterEach" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:4:21] ╭─[prefer_hooks_in_order.tsx:3:21]
2 │ describe('my test', () => {
3 │ afterAll(() => {}); 3 │ afterAll(() => {});
· ─────────┬────────
· ╰── "afterEach" hook should be called before this
4 │ afterEach(() => {}); 4 │ afterEach(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
5 │ 5 │
╰──── ╰────
help: "afterEach" hooks should be before any "afterAll" hooks help: "afterEach" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:9:21] ╭─[prefer_hooks_in_order.tsx:8:21]
7 │
8 │ beforeEach(() => {}); 8 │ beforeEach(() => {});
· ──────────┬─────────
· ╰── "beforeAll" hook should be called before this
9 │ beforeAll(() => {}); 9 │ beforeAll(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "beforeEach" hook
10 │ }); 10 │ });
╰──── ╰────
help: "beforeAll" hooks should be before any "beforeEach" hooks help: "beforeAll" hooks should be before any "beforeEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:4:21] ╭─[prefer_hooks_in_order.tsx:3:21]
2 │ describe('my test', () => {
3 │ afterAll(() => {}); 3 │ afterAll(() => {});
· ─────────┬────────
· ╰── "afterEach" hook should be called before this
4 │ afterEach(() => {}); 4 │ afterEach(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
5 │ 5 │
╰──── ╰────
help: "afterEach" hooks should be before any "afterAll" hooks help: "afterEach" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:9:21] ╭─[prefer_hooks_in_order.tsx:8:21]
7 │
8 │ beforeEach(() => {}); 8 │ beforeEach(() => {});
· ──────────┬─────────
· ╰── "beforeAll" hook should be called before this
9 │ beforeAll(() => {}); 9 │ beforeAll(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "beforeEach" hook
10 │ }); 10 │ });
╰──── ╰────
help: "beforeAll" hooks should be before any "beforeEach" hooks help: "beforeAll" hooks should be before any "beforeEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:7:25] ╭─[prefer_hooks_in_order.tsx:6:25]
5 │ describe('when something is true', () => {
6 │ beforeEach(() => {}); 6 │ beforeEach(() => {});
· ──────────┬─────────
· ╰── "beforeAll" hook should be called before this
7 │ beforeAll(() => {}); 7 │ beforeAll(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "beforeEach" hook
8 │ }); 8 │ });
╰──── ╰────
help: "beforeAll" hooks should be before any "beforeEach" hooks help: "beforeAll" hooks should be before any "beforeEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:5:21] ╭─[prefer_hooks_in_order.tsx:4:21]
3 │ beforeAll(() => {});
4 │ afterAll(() => {}); 4 │ afterAll(() => {});
· ─────────┬────────
· ╰── "beforeAll" hook should be called before this
5 │ beforeAll(() => {}); 5 │ beforeAll(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
6 │ 6 │
╰──── ╰────
help: "beforeAll" hooks should be before any "afterAll" hooks help: "beforeAll" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:10:25] ╭─[prefer_hooks_in_order.tsx:9:25]
8 │ beforeAll(() => {});
9 │ afterEach(() => {}); 9 │ afterEach(() => {});
· ─────────┬─────────
· ╰── "beforeEach" hook should be called before this
10 │ beforeEach(() => {}); 10 │ beforeEach(() => {});
· ──────────────────── · ──────────┬─────────
· ╰── this should be moved to before the "afterEach" hook
11 │ afterEach(() => {}); 11 │ afterEach(() => {});
╰──── ╰────
help: "beforeEach" hooks should be before any "afterEach" hooks help: "beforeEach" hooks should be before any "afterEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:23:29] ╭─[prefer_hooks_in_order.tsx:21:29]
20 │ afterAll(() => {});
21 │ afterAll(() => {});
· ─────────┬────────
· ╰── "afterEach" hook should be called before this
22 │ // This comment does nothing 22 │ // This comment does nothing
23 │ afterEach(() => {}); 23 │ afterEach(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
24 │ 24 │
╰──── ╰────
help: "afterEach" hooks should be before any "afterAll" hooks help: "afterEach" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:8:25] ╭─[prefer_hooks_in_order.tsx:4:25]
7 │ }); 3 │ const setupDatabase = () => {
4 │ ╭─▶ beforeEach(() => {
5 │ │ initDatabase();
6 │ │ fillWithData();
7 │ ├─▶ });
· ╰──── "beforeAll" hook should be called before this
8 │ ╭─▶ beforeAll(() => { 8 │ ╭─▶ beforeAll(() => {
9 │ │ setupMocks(); 9 │ │ setupMocks();
10 │ ╰─▶ }); 10 │ ├─▶ });
· ╰──── this should be moved to before the "beforeEach" hook
11 │ }; 11 │ };
╰──── ╰────
help: "beforeAll" hooks should be before any "beforeEach" hooks help: "beforeAll" hooks should be before any "beforeEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:19:25] ╭─[prefer_hooks_in_order.tsx:18:25]
17 │ describe('my nested test', () => {
18 │ afterAll(() => {}); 18 │ afterAll(() => {});
· ─────────┬────────
· ╰── "afterEach" hook should be called before this
19 │ afterEach(() => {}); 19 │ afterEach(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
20 │ 20 │
╰──── ╰────
help: "afterEach" hooks should be before any "afterAll" hooks help: "afterEach" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:7:21] ╭─[prefer_hooks_in_order.tsx:3:21]
2 │ describe('foo', () => {
3 │ ╭─▶ beforeEach(() => {
4 │ │ seedMyDatabase();
5 │ ├─▶ });
· ╰──── "beforeAll" hook should be called before this
6 │ 6 │
7 │ ╭─▶ beforeAll(() => { 7 │ ╭─▶ beforeAll(() => {
8 │ │ createMyDatabase(); 8 │ │ createMyDatabase();
9 │ ╰─▶ }); 9 │ ├─▶ });
· ╰──── this should be moved to before the "beforeEach" hook
10 │ 10 │
╰──── ╰────
help: "beforeAll" hooks should be before any "beforeEach" hooks help: "beforeAll" hooks should be before any "beforeEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:38:25] ╭─[prefer_hooks_in_order.tsx:34:25]
33 │
34 │ ╭─▶ afterEach(() => {
35 │ │ clearLogger();
36 │ ├─▶ });
· ╰──── "beforeEach" hook should be called before this
37 │ 37 │
38 │ ╭─▶ beforeEach(() => { 38 │ ╭─▶ beforeEach(() => {
39 │ │ mockLogger(); 39 │ │ mockLogger();
40 │ ╰─▶ }); 40 │ ├─▶ });
· ╰──── this should be moved to before the "afterEach" hook
41 │ 41 │
╰──── ╰────
help: "beforeEach" hooks should be before any "afterEach" hooks help: "beforeEach" hooks should be before any "afterEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:6:17] ╭─[prefer_hooks_in_order.tsx:3:17]
5 │ }); 2 │ const withDatabase = () => {
3 │ ╭─▶ afterAll(() => {
4 │ │ removeMyDatabase();
5 │ ├─▶ });
· ╰──── "beforeAll" hook should be called before this
6 │ ╭─▶ beforeAll(() => { 6 │ ╭─▶ beforeAll(() => {
7 │ │ createMyDatabase(); 7 │ │ createMyDatabase();
8 │ ╰─▶ }); 8 │ ├─▶ });
· ╰──── this should be moved to before the "afterAll" hook
9 │ }; 9 │ };
╰──── ╰────
help: "beforeAll" hooks should be before any "afterAll" hooks help: "beforeAll" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:5:13] ╭─[prefer_hooks_in_order.tsx:2:13]
4 │ }); 1 │
2 │ ╭─▶ afterAll(() => {
3 │ │ removeMyDatabase();
4 │ ├─▶ });
· ╰──── "beforeAll" hook should be called before this
5 │ ╭─▶ beforeAll(() => { 5 │ ╭─▶ beforeAll(() => {
6 │ │ createMyDatabase(); 6 │ │ createMyDatabase();
7 │ ╰─▶ }); 7 │ ├─▶ });
· ╰──── this should be moved to before the "afterAll" hook
8 │ 8 │
╰──── ╰────
help: "beforeAll" hooks should be before any "afterAll" hooks help: "beforeAll" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:3:13] ╭─[prefer_hooks_in_order.tsx:2:13]
1 │
2 │ afterAll(() => {}); 2 │ afterAll(() => {});
· ─────────┬────────
· ╰── "beforeAll" hook should be called before this
3 │ beforeAll(() => {}); 3 │ beforeAll(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
4 │ 4 │
╰──── ╰────
help: "beforeAll" hooks should be before any "afterAll" hooks help: "beforeAll" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:3:13] ╭─[prefer_hooks_in_order.tsx:2:13]
1 │
2 │ afterEach(() => {}); 2 │ afterEach(() => {});
· ─────────┬─────────
· ╰── "beforeEach" hook should be called before this
3 │ beforeEach(() => {}); 3 │ beforeEach(() => {});
· ──────────────────── · ──────────┬─────────
· ╰── this should be moved to before the "afterEach" hook
4 │ 4 │
╰──── ╰────
help: "beforeEach" hooks should be before any "afterEach" hooks help: "beforeEach" hooks should be before any "afterEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:3:13] ╭─[prefer_hooks_in_order.tsx:2:13]
1 │
2 │ afterEach(() => {}); 2 │ afterEach(() => {});
· ─────────┬─────────
· ╰── "beforeAll" hook should be called before this
3 │ beforeAll(() => {}); 3 │ beforeAll(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterEach" hook
4 │ 4 │
╰──── ╰────
help: "beforeAll" hooks should be before any "afterEach" hooks help: "beforeAll" hooks should be before any "afterEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:3:13] ╭─[prefer_hooks_in_order.tsx:2:13]
1 │
2 │ beforeEach(() => {}); 2 │ beforeEach(() => {});
· ──────────┬─────────
· ╰── "beforeAll" hook should be called before this
3 │ beforeAll(() => {}); 3 │ beforeAll(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "beforeEach" hook
4 │ 4 │
╰──── ╰────
help: "beforeAll" hooks should be before any "beforeEach" hooks help: "beforeAll" hooks should be before any "beforeEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:3:13] ╭─[prefer_hooks_in_order.tsx:2:13]
1 │
2 │ afterAll(() => {}); 2 │ afterAll(() => {});
· ─────────┬────────
· ╰── "afterEach" hook should be called before this
3 │ afterEach(() => {}); 3 │ afterEach(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
4 │ 4 │
╰──── ╰────
help: "afterEach" hooks should be before any "afterAll" hooks help: "afterEach" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:5:13] ╭─[prefer_hooks_in_order.tsx:2:13]
1 │
2 │ afterAll(() => {});
· ─────────┬────────
· ╰── "afterEach" hook should be called before this
3 │ // The afterEach should do this
4 │ // This comment does not matter for the order 4 │ // This comment does not matter for the order
5 │ afterEach(() => {}); 5 │ afterEach(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
6 │ 6 │
╰──── ╰────
help: "afterEach" hooks should be before any "afterAll" hooks help: "afterEach" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:4:13] ╭─[prefer_hooks_in_order.tsx:3:13]
2 │ afterAll(() => {});
3 │ afterAll(() => {}); 3 │ afterAll(() => {});
· ─────────┬────────
· ╰── "afterEach" hook should be called before this
4 │ afterEach(() => {}); 4 │ afterEach(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
5 │ 5 │
╰──── ╰────
help: "afterEach" hooks should be before any "afterAll" hooks help: "afterEach" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:4:17] ╭─[prefer_hooks_in_order.tsx:3:17]
2 │ describe('my test', () => {
3 │ afterAll(() => {}); 3 │ afterAll(() => {});
· ─────────┬────────
· ╰── "afterEach" hook should be called before this
4 │ afterEach(() => {}); 4 │ afterEach(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
5 │ }); 5 │ });
╰──── ╰────
help: "afterEach" hooks should be before any "afterAll" hooks help: "afterEach" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:4:17] ╭─[prefer_hooks_in_order.tsx:3:17]
2 │ describe('my test', () => {
3 │ afterAll(() => {}); 3 │ afterAll(() => {});
· ─────────┬────────
· ╰── "afterEach" hook should be called before this
4 │ afterEach(() => {}); 4 │ afterEach(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
5 │ 5 │
╰──── ╰────
help: "afterEach" hooks should be before any "afterAll" hooks help: "afterEach" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:9:17] ╭─[prefer_hooks_in_order.tsx:8:17]
7 │
8 │ beforeEach(() => {}); 8 │ beforeEach(() => {});
· ──────────┬─────────
· ╰── "beforeAll" hook should be called before this
9 │ beforeAll(() => {}); 9 │ beforeAll(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "beforeEach" hook
10 │ }); 10 │ });
╰──── ╰────
help: "beforeAll" hooks should be before any "beforeEach" hooks help: "beforeAll" hooks should be before any "beforeEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:4:17] ╭─[prefer_hooks_in_order.tsx:3:17]
2 │ describe('my test', () => {
3 │ afterAll(() => {}); 3 │ afterAll(() => {});
· ─────────┬────────
· ╰── "afterEach" hook should be called before this
4 │ afterEach(() => {}); 4 │ afterEach(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
5 │ 5 │
╰──── ╰────
help: "afterEach" hooks should be before any "afterAll" hooks help: "afterEach" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:9:17] ╭─[prefer_hooks_in_order.tsx:8:17]
7 │
8 │ beforeEach(() => {}); 8 │ beforeEach(() => {});
· ──────────┬─────────
· ╰── "beforeAll" hook should be called before this
9 │ beforeAll(() => {}); 9 │ beforeAll(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "beforeEach" hook
10 │ }); 10 │ });
╰──── ╰────
help: "beforeAll" hooks should be before any "beforeEach" hooks help: "beforeAll" hooks should be before any "beforeEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:7:21] ╭─[prefer_hooks_in_order.tsx:6:21]
5 │ describe('when something is true', () => {
6 │ beforeEach(() => {}); 6 │ beforeEach(() => {});
· ──────────┬─────────
· ╰── "beforeAll" hook should be called before this
7 │ beforeAll(() => {}); 7 │ beforeAll(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "beforeEach" hook
8 │ }); 8 │ });
╰──── ╰────
help: "beforeAll" hooks should be before any "beforeEach" hooks help: "beforeAll" hooks should be before any "beforeEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:5:17] ╭─[prefer_hooks_in_order.tsx:4:17]
3 │ beforeAll(() => {});
4 │ afterAll(() => {}); 4 │ afterAll(() => {});
· ─────────┬────────
· ╰── "beforeAll" hook should be called before this
5 │ beforeAll(() => {}); 5 │ beforeAll(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
6 │ 6 │
╰──── ╰────
help: "beforeAll" hooks should be before any "afterAll" hooks help: "beforeAll" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:10:21] ╭─[prefer_hooks_in_order.tsx:9:21]
8 │ beforeAll(() => {});
9 │ afterEach(() => {}); 9 │ afterEach(() => {});
· ─────────┬─────────
· ╰── "beforeEach" hook should be called before this
10 │ beforeEach(() => {}); 10 │ beforeEach(() => {});
· ──────────────────── · ──────────┬─────────
· ╰── this should be moved to before the "afterEach" hook
11 │ afterEach(() => {}); 11 │ afterEach(() => {});
╰──── ╰────
help: "beforeEach" hooks should be before any "afterEach" hooks help: "beforeEach" hooks should be before any "afterEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:23:25] ╭─[prefer_hooks_in_order.tsx:21:25]
20 │ afterAll(() => {});
21 │ afterAll(() => {});
· ─────────┬────────
· ╰── "afterEach" hook should be called before this
22 │ // This comment does nothing 22 │ // This comment does nothing
23 │ afterEach(() => {}); 23 │ afterEach(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
24 │ 24 │
╰──── ╰────
help: "afterEach" hooks should be before any "afterAll" hooks help: "afterEach" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:8:21] ╭─[prefer_hooks_in_order.tsx:4:21]
7 │ }); 3 │ const setupDatabase = () => {
4 │ ╭─▶ beforeEach(() => {
5 │ │ initDatabase();
6 │ │ fillWithData();
7 │ ├─▶ });
· ╰──── "beforeAll" hook should be called before this
8 │ ╭─▶ beforeAll(() => { 8 │ ╭─▶ beforeAll(() => {
9 │ │ setupMocks(); 9 │ │ setupMocks();
10 │ ╰─▶ }); 10 │ ├─▶ });
· ╰──── this should be moved to before the "beforeEach" hook
11 │ }; 11 │ };
╰──── ╰────
help: "beforeAll" hooks should be before any "beforeEach" hooks help: "beforeAll" hooks should be before any "beforeEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:19:21] ╭─[prefer_hooks_in_order.tsx:18:21]
17 │ describe('my nested test', () => {
18 │ afterAll(() => {}); 18 │ afterAll(() => {});
· ─────────┬────────
· ╰── "afterEach" hook should be called before this
19 │ afterEach(() => {}); 19 │ afterEach(() => {});
· ─────────────────── · ─────────┬─────────
· ╰── this should be moved to before the "afterAll" hook
20 │ 20 │
╰──── ╰────
help: "afterEach" hooks should be before any "afterAll" hooks help: "afterEach" hooks should be before any "afterAll" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:7:17] ╭─[prefer_hooks_in_order.tsx:3:17]
2 │ describe('foo', () => {
3 │ ╭─▶ beforeEach(() => {
4 │ │ seedMyDatabase();
5 │ ├─▶ });
· ╰──── "beforeAll" hook should be called before this
6 │ 6 │
7 │ ╭─▶ beforeAll(() => { 7 │ ╭─▶ beforeAll(() => {
8 │ │ createMyDatabase(); 8 │ │ createMyDatabase();
9 │ ╰─▶ }); 9 │ ├─▶ });
· ╰──── this should be moved to before the "beforeEach" hook
10 │ 10 │
╰──── ╰────
help: "beforeAll" hooks should be before any "beforeEach" hooks help: "beforeAll" hooks should be before any "beforeEach" hooks
⚠ eslint-plugin-vitest(prefer-hooks-in-order): Prefer having hooks in a consistent order. ⚠ eslint-plugin-vitest(prefer-hooks-in-order): Test hooks are not in a consistent order.
╭─[prefer_hooks_in_order.tsx:38:21] ╭─[prefer_hooks_in_order.tsx:34:21]
33 │
34 │ ╭─▶ afterEach(() => {
35 │ │ clearLogger();
36 │ ├─▶ });
· ╰──── "beforeEach" hook should be called before this
37 │ 37 │
38 │ ╭─▶ beforeEach(() => { 38 │ ╭─▶ beforeEach(() => {
39 │ │ mockLogger(); 39 │ │ mockLogger();
40 │ ╰─▶ }); 40 │ ├─▶ });
· ╰──── this should be moved to before the "afterEach" hook
41 │ 41 │
╰──── ╰────
help: "beforeEach" hooks should be before any "afterEach" hooks help: "beforeEach" hooks should be before any "afterEach" hooks