dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(linter): simplify eslint/radix rule (#5445)

Browse source 
Refactor to remove duplicate logic.
This commit is contained in:
overlookmotel 2024-09-04 16:52:27 +00:00
parent 9c937e06e8
commit 1d3e973f10
1 changed files with 9 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
crates/oxc_linter/src/rules/eslint/radix.rs
View file

@ -67,36 +67,29 @@ impl Rule for Radix {
fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) { fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
if let AstKind::CallExpression(call_expr) = node.kind() { if let AstKind::CallExpression(call_expr) = node.kind() {
match &call_expr.callee.without_parenthesized() { match call_expr.callee.without_parenthesized() {
Expression::Identifier(ident) if ident.name == "parseInt" => { Expression::Identifier(ident) => {
if ctx.symbols().get_symbol_id_from_name("parseInt").is_none() { if ident.name == "parseInt"
&& ctx.symbols().get_symbol_id_from_name("parseInt").is_none()
{
Self::check_arguments(self, call_expr, ctx); Self::check_arguments(self, call_expr, ctx);
} }
} }
Expression::StaticMemberExpression(member_expr) => { Expression::StaticMemberExpression(member_expr) => {
if let Expression::Identifier(ident) = &member_expr.object { if let Expression::Identifier(ident) =
member_expr.object.without_parenthesized()
{
if ident.name == "Number" if ident.name == "Number"
&& member_expr.property.name == "parseInt" && member_expr.property.name == "parseInt"
&& ctx.symbols().get_symbol_id_from_name("Number").is_none() && ctx.symbols().get_symbol_id_from_name("Number").is_none()
{ {
Self::check_arguments(self, call_expr, ctx); Self::check_arguments(self, call_expr, ctx);
} }
} else if let Expression::ParenthesizedExpression(paren_expr) =
&member_expr.object
{
if let Expression::Identifier(ident) = &paren_expr.expression {
if ident.name == "Number"
&& member_expr.property.name == "parseInt"
&& ctx.symbols().get_symbol_id_from_name("Number").is_none()
{
Self::check_arguments(self, call_expr, ctx);
}
}
} }
} }
Expression::ChainExpression(chain_expr) => { Expression::ChainExpression(chain_expr) => {
if let Some(member_expr) = chain_expr.expression.as_member_expression() { if let Some(member_expr) = chain_expr.expression.as_member_expression() {
if let Expression::Identifier(ident) = &member_expr.object() { if let Expression::Identifier(ident) = member_expr.object() {
if ident.name == "Number" if ident.name == "Number"
&& member_expr.static_property_name() == Some("parseInt") && member_expr.static_property_name() == Some("parseInt")
&& ctx.symbols().get_symbol_id_from_name("Number").is_none() && ctx.symbols().get_symbol_id_from_name("Number").is_none()