mirror of
https://github.com/danbulant/oxc
synced 2026-05-24 12:21:58 +00:00
feat(linter): eslint-plugin-jest: no-restricted-jest-methods (#2091)
Rule Detail: [link](https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/no-restricted-jest-methods.ts) --------- Co-authored-by: Wenzhe Wang <mysteryven@gmail.com>
This commit is contained in:
parent
142f84f654
commit
16b32616c4
3 changed files with 249 additions and 0 deletions
|
|
@ -132,6 +132,7 @@ mod jest {
|
||||||
pub mod no_interpolation_in_snapshots;
|
pub mod no_interpolation_in_snapshots;
|
||||||
pub mod no_jasmine_globals;
|
pub mod no_jasmine_globals;
|
||||||
pub mod no_mocks_import;
|
pub mod no_mocks_import;
|
||||||
|
pub mod no_restricted_jest_methods;
|
||||||
pub mod no_restricted_matchers;
|
pub mod no_restricted_matchers;
|
||||||
pub mod no_standalone_expect;
|
pub mod no_standalone_expect;
|
||||||
pub mod no_test_prefixes;
|
pub mod no_test_prefixes;
|
||||||
|
|
@ -405,6 +406,7 @@ oxc_macros::declare_all_lint_rules! {
|
||||||
jest::no_interpolation_in_snapshots,
|
jest::no_interpolation_in_snapshots,
|
||||||
jest::no_jasmine_globals,
|
jest::no_jasmine_globals,
|
||||||
jest::no_mocks_import,
|
jest::no_mocks_import,
|
||||||
|
jest::no_restricted_jest_methods,
|
||||||
jest::no_restricted_matchers,
|
jest::no_restricted_matchers,
|
||||||
jest::no_standalone_expect,
|
jest::no_standalone_expect,
|
||||||
jest::no_test_prefixes,
|
jest::no_test_prefixes,
|
||||||
|
|
|
||||||
204
crates/oxc_linter/src/rules/jest/no_restricted_jest_methods.rs
Normal file
204
crates/oxc_linter/src/rules/jest/no_restricted_jest_methods.rs
Normal file
|
|
@ -0,0 +1,204 @@
|
||||||
|
use crate::{
|
||||||
|
context::LintContext,
|
||||||
|
rule::Rule,
|
||||||
|
utils::{
|
||||||
|
collect_possible_jest_call_node, is_type_of_jest_fn_call, JestFnKind, JestGeneralFnKind,
|
||||||
|
PossibleJestNode,
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
use oxc_ast::{ast::Expression, AstKind};
|
||||||
|
use oxc_diagnostics::{
|
||||||
|
miette::{self, Diagnostic},
|
||||||
|
thiserror::Error,
|
||||||
|
};
|
||||||
|
use oxc_macros::declare_oxc_lint;
|
||||||
|
use oxc_span::Span;
|
||||||
|
use rustc_hash::{FxHashMap, FxHasher};
|
||||||
|
use std::{collections::HashMap, hash::BuildHasherDefault};
|
||||||
|
|
||||||
|
#[derive(Debug, Error, Diagnostic)]
|
||||||
|
enum NoRestrictedJestMethodsDiagnostic {
|
||||||
|
#[error("eslint-plugin-jest(no-restricted-jest-methods): Disallow specific `jest.` methods")]
|
||||||
|
#[diagnostic(severity(warning), help("Use of `{0:?}` is disallowed"))]
|
||||||
|
RestrictedJestMethod(String, #[label] Span),
|
||||||
|
#[error("eslint-plugin-jest(no-restricted-jest-methods): Disallow specific `jest.` methods")]
|
||||||
|
#[diagnostic(severity(warning), help("{0:?}"))]
|
||||||
|
RestrictedJestMethodWithMessage(String, #[label] Span),
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Default, Clone)]
|
||||||
|
pub struct NoRestrictedJestMethods(Box<NoRestrictedJestMethodsConfig>);
|
||||||
|
|
||||||
|
#[derive(Debug, Default, Clone)]
|
||||||
|
pub struct NoRestrictedJestMethodsConfig {
|
||||||
|
restricted_jest_methods: FxHashMap<String, String>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl std::ops::Deref for NoRestrictedJestMethods {
|
||||||
|
type Target = NoRestrictedJestMethodsConfig;
|
||||||
|
|
||||||
|
fn deref(&self) -> &Self::Target {
|
||||||
|
&self.0
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
declare_oxc_lint!(
|
||||||
|
/// ### What it does
|
||||||
|
///
|
||||||
|
/// Restrict the use of specific `jest` methods.
|
||||||
|
///
|
||||||
|
/// ### Example
|
||||||
|
/// ```javascript
|
||||||
|
/// jest.useFakeTimers();
|
||||||
|
/// it('calls the callback after 1 second via advanceTimersByTime', () => {
|
||||||
|
/// // ...
|
||||||
|
///
|
||||||
|
/// jest.advanceTimersByTime(1000);
|
||||||
|
///
|
||||||
|
/// // ...
|
||||||
|
/// });
|
||||||
|
///
|
||||||
|
/// test('plays video', () => {
|
||||||
|
/// const spy = jest.spyOn(video, 'play');
|
||||||
|
///
|
||||||
|
/// // ...
|
||||||
|
/// });
|
||||||
|
///
|
||||||
|
NoRestrictedJestMethods,
|
||||||
|
style,
|
||||||
|
);
|
||||||
|
|
||||||
|
impl Rule for NoRestrictedJestMethods {
|
||||||
|
fn from_configuration(value: serde_json::Value) -> Self {
|
||||||
|
let restricted_jest_methods = &value
|
||||||
|
.get(0)
|
||||||
|
.and_then(serde_json::Value::as_object)
|
||||||
|
.and_then(Self::compile_restricted_jest_methods)
|
||||||
|
.unwrap_or_default();
|
||||||
|
|
||||||
|
Self(Box::new(NoRestrictedJestMethodsConfig {
|
||||||
|
restricted_jest_methods: restricted_jest_methods.clone(),
|
||||||
|
}))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn run_once(&self, ctx: &LintContext) {
|
||||||
|
for possible_jest_node in &collect_possible_jest_call_node(ctx) {
|
||||||
|
self.run(possible_jest_node, ctx);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
impl NoRestrictedJestMethods {
|
||||||
|
fn contains(&self, key: &str) -> bool {
|
||||||
|
self.restricted_jest_methods.contains_key(key)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn get_message(&self, name: &str) -> Option<String> {
|
||||||
|
self.restricted_jest_methods.get(name).cloned()
|
||||||
|
}
|
||||||
|
|
||||||
|
fn run<'a>(&self, possible_jest_node: &PossibleJestNode<'a, '_>, ctx: &LintContext<'a>) {
|
||||||
|
let node = possible_jest_node.node;
|
||||||
|
let AstKind::CallExpression(call_expr) = node.kind() else {
|
||||||
|
return;
|
||||||
|
};
|
||||||
|
|
||||||
|
if !is_type_of_jest_fn_call(
|
||||||
|
call_expr,
|
||||||
|
possible_jest_node,
|
||||||
|
ctx,
|
||||||
|
&[JestFnKind::General(JestGeneralFnKind::Jest)],
|
||||||
|
) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
let Expression::MemberExpression(mem_expr) = &call_expr.callee else {
|
||||||
|
return;
|
||||||
|
};
|
||||||
|
let Some(property_name) = mem_expr.static_property_name() else {
|
||||||
|
return;
|
||||||
|
};
|
||||||
|
let Some((span, _)) = mem_expr.static_property_info() else {
|
||||||
|
return;
|
||||||
|
};
|
||||||
|
|
||||||
|
if self.contains(property_name) {
|
||||||
|
self.get_message(property_name).map_or_else(
|
||||||
|
|| {
|
||||||
|
ctx.diagnostic(NoRestrictedJestMethodsDiagnostic::RestrictedJestMethod(
|
||||||
|
property_name.to_string(),
|
||||||
|
span,
|
||||||
|
));
|
||||||
|
},
|
||||||
|
|message| {
|
||||||
|
if message.trim() == "" {
|
||||||
|
ctx.diagnostic(NoRestrictedJestMethodsDiagnostic::RestrictedJestMethod(
|
||||||
|
property_name.to_string(),
|
||||||
|
span,
|
||||||
|
));
|
||||||
|
} else {
|
||||||
|
ctx.diagnostic(
|
||||||
|
NoRestrictedJestMethodsDiagnostic::RestrictedJestMethodWithMessage(
|
||||||
|
message, span,
|
||||||
|
),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
},
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[allow(clippy::unnecessary_wraps)]
|
||||||
|
pub fn compile_restricted_jest_methods(
|
||||||
|
matchers: &serde_json::Map<String, serde_json::Value>,
|
||||||
|
) -> Option<HashMap<String, String, BuildHasherDefault<FxHasher>>> {
|
||||||
|
Some(
|
||||||
|
matchers
|
||||||
|
.iter()
|
||||||
|
.map(|(key, value)| {
|
||||||
|
(String::from(key), String::from(value.as_str().unwrap_or_default()))
|
||||||
|
})
|
||||||
|
.collect(),
|
||||||
|
)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn test() {
|
||||||
|
use crate::tester::Tester;
|
||||||
|
|
||||||
|
let pass = vec![
|
||||||
|
("jest", None),
|
||||||
|
("jest()", None),
|
||||||
|
("jest.mock()", None),
|
||||||
|
("expect(a).rejects;", None),
|
||||||
|
("expect(a);", None),
|
||||||
|
(
|
||||||
|
"
|
||||||
|
import { jest } from '@jest/globals';
|
||||||
|
|
||||||
|
jest;
|
||||||
|
",
|
||||||
|
None,
|
||||||
|
),
|
||||||
|
];
|
||||||
|
|
||||||
|
let fail = vec![
|
||||||
|
("jest.fn()", Some(serde_json::json!([{ "fn": null }]))),
|
||||||
|
("jest[\"fn\"]()", Some(serde_json::json!([{ "fn": null }]))),
|
||||||
|
("jest.mock()", Some(serde_json::json!([{ "mock": "Do not use mocks" }]))),
|
||||||
|
("jest[\"mock\"]()", Some(serde_json::json!([{ "mock": "Do not use mocks" }]))),
|
||||||
|
(
|
||||||
|
"
|
||||||
|
import { jest } from '@jest/globals';
|
||||||
|
jest.advanceTimersByTime();
|
||||||
|
",
|
||||||
|
Some(serde_json::json!([{ "advanceTimersByTime": null }])),
|
||||||
|
),
|
||||||
|
];
|
||||||
|
|
||||||
|
Tester::new(NoRestrictedJestMethods::NAME, pass, fail)
|
||||||
|
.with_jest_plugin(true)
|
||||||
|
.test_and_snapshot();
|
||||||
|
}
|
||||||
|
|
@ -0,0 +1,43 @@
|
||||||
|
---
|
||||||
|
source: crates/oxc_linter/src/tester.rs
|
||||||
|
assertion_line: 143
|
||||||
|
expression: no_restricted_jest_methods
|
||||||
|
---
|
||||||
|
⚠ eslint-plugin-jest(no-restricted-jest-methods): Disallow specific `jest.` methods
|
||||||
|
╭─[no_restricted_jest_methods.tsx:1:1]
|
||||||
|
1 │ jest.fn()
|
||||||
|
· ──
|
||||||
|
╰────
|
||||||
|
help: Use of `"fn"` is disallowed
|
||||||
|
|
||||||
|
⚠ eslint-plugin-jest(no-restricted-jest-methods): Disallow specific `jest.` methods
|
||||||
|
╭─[no_restricted_jest_methods.tsx:1:1]
|
||||||
|
1 │ jest["fn"]()
|
||||||
|
· ────
|
||||||
|
╰────
|
||||||
|
help: Use of `"fn"` is disallowed
|
||||||
|
|
||||||
|
⚠ eslint-plugin-jest(no-restricted-jest-methods): Disallow specific `jest.` methods
|
||||||
|
╭─[no_restricted_jest_methods.tsx:1:1]
|
||||||
|
1 │ jest.mock()
|
||||||
|
· ────
|
||||||
|
╰────
|
||||||
|
help: "Do not use mocks"
|
||||||
|
|
||||||
|
⚠ eslint-plugin-jest(no-restricted-jest-methods): Disallow specific `jest.` methods
|
||||||
|
╭─[no_restricted_jest_methods.tsx:1:1]
|
||||||
|
1 │ jest["mock"]()
|
||||||
|
· ──────
|
||||||
|
╰────
|
||||||
|
help: "Do not use mocks"
|
||||||
|
|
||||||
|
⚠ eslint-plugin-jest(no-restricted-jest-methods): Disallow specific `jest.` methods
|
||||||
|
╭─[no_restricted_jest_methods.tsx:2:1]
|
||||||
|
2 │ import { jest } from '@jest/globals';
|
||||||
|
3 │ jest.advanceTimersByTime();
|
||||||
|
· ───────────────────
|
||||||
|
4 │
|
||||||
|
╰────
|
||||||
|
help: Use of `"advanceTimersByTime"` is disallowed
|
||||||
|
|
||||||
|
|
||||||
Loading…
Reference in a new issue