dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(syntax): correct is_reserved_keyword_or_global_object's incorrect function calling. (#4484)

Browse source 
It may be a problem, but doesn't matter previously.

Formerly, the `is_reserved_keyword_or_global_object` is
`is_reserved_keyword(s) || is_reserved_keyword(s)`. I think it should be
`is_reserved_keyword(s) || is_global_object(s)` according to its name.

Also, the `.idea` may be because I am using RustRover, which may
automatically create `.idea` folder. So I ignore it in `.gitignore`.

I think I can contribute to `oxc` more when I am free.
This commit is contained in:
Ethan Goh 2024-07-27 05:20:10 +08:00 committed by GitHub
parent 5c40dadb14
commit 1667491868
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.gitignore vendored
View file

@ -1,5 +1,6 @@
target/ target/
**/*.rs.bk **/*.rs.bk
.idea
/node_modules/ /node_modules/
/website/node_modules/ /website/node_modules/

2
crates/oxc_syntax/src/keyword.rs
View file

@ -2,7 +2,7 @@ use phf::{phf_set, Set};
#[inline] #[inline]
pub fn is_reserved_keyword_or_global_object(s: &str) -> bool { pub fn is_reserved_keyword_or_global_object(s: &str) -> bool {
is_reserved_keyword(s) || is_reserved_keyword(s) is_reserved_keyword(s) || is_global_object(s)
} }
#[inline] #[inline]