dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(transformer/typescript): reuse Atom (#7969)

Browse source 
Re-use existing `Atom` rather than allocating multiple copies of it into the arena.
This commit is contained in:
overlookmotel 2024-12-18 02:54:29 +00:00
parent 6551dfef5c
commit 15b9bffe16
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
crates/oxc_transformer/src/typescript/namespace.rs
View file

@ -315,8 +315,6 @@ impl<'a, 'ctx> TypeScriptNamespace<'a, 'ctx> {
} }
// `namespace Foo { }` -> `let Foo; (function (_Foo) { })(Foo || (Foo = {}));` // `namespace Foo { }` -> `let Foo; (function (_Foo) { })(Foo || (Foo = {}));`
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#[allow(clippy::needless_pass_by_value, clippy::too_many_arguments)]
fn transform_namespace( fn transform_namespace(
arg_name: Atom<'a>, arg_name: Atom<'a>,
real_name: Atom<'a>, real_name: Atom<'a>,
@ -355,7 +353,7 @@ impl<'a, 'ctx> TypeScriptNamespace<'a, 'ctx> {
// Nested namespace arguments Normal namespace arguments // Nested namespace arguments Normal namespace arguments
let arguments = { let arguments = {
// M // M
let logical_left = ctx.ast.expression_identifier_reference(SPAN, &real_name); let logical_left = ctx.ast.expression_identifier_reference(SPAN, real_name.clone());
// (_N.M = {}) or (N = {}) // (_N.M = {}) or (N = {})
let mut logical_right = { let mut logical_right = {
@ -387,9 +385,9 @@ impl<'a, 'ctx> TypeScriptNamespace<'a, 'ctx> {
// (M = _N.M || (_N.M = {})) // (M = _N.M || (_N.M = {}))
if let Some(parent_export) = parent_export { if let Some(parent_export) = parent_export {
let assign_left = let assign_left =
ctx.ast.simple_assignment_target_identifier_reference(SPAN, &real_name); ctx.ast.simple_assignment_target_identifier_reference(SPAN, real_name.clone());
let assign_right = { let assign_right = {
let property = ctx.ast.identifier_name(SPAN, real_name.clone()); let property = ctx.ast.identifier_name(SPAN, real_name);
let logical_left = let logical_left =
ctx.ast.member_expression_static(SPAN, parent_export, property, false); ctx.ast.member_expression_static(SPAN, parent_export, property, false);
let op = LogicalOperator::Or; let op = LogicalOperator::Or;
@ -446,7 +444,7 @@ impl<'a, 'ctx> TypeScriptNamespace<'a, 'ctx> {
} }
/// Convert `export const foo = 1` to `Namespace.foo = 1`; /// Convert `export const foo = 1` to `Namespace.foo = 1`;
#[allow(clippy::needless_pass_by_value)] #[expect(clippy::needless_pass_by_value)]
fn handle_variable_declaration( fn handle_variable_declaration(
mut var_decl: ArenaBox<'a, VariableDeclaration<'a>>, mut var_decl: ArenaBox<'a, VariableDeclaration<'a>>,
name: Atom<'a>, name: Atom<'a>,
@ -471,7 +469,7 @@ impl<'a, 'ctx> TypeScriptNamespace<'a, 'ctx> {
AssignmentOperator::Assign, AssignmentOperator::Assign,
SimpleAssignmentTarget::from(ctx.ast.member_expression_static( SimpleAssignmentTarget::from(ctx.ast.member_expression_static(
SPAN, SPAN,
ctx.ast.expression_identifier_reference(SPAN, &name), ctx.ast.expression_identifier_reference(SPAN, name.clone()),
ctx.ast.identifier_name(SPAN, property_name), ctx.ast.identifier_name(SPAN, property_name),
false, false,
)) ))