dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(visit): add #[inline] to empty functions (#4330)

Browse source 
Add `#[inline]` to empty default implementations of `enter_node` etc. Hopefully compiler will inline them automatically within Oxc even cross-crate because we compile with LTO, but maybe not for external consumers who don't use LTO.
This commit is contained in:
overlookmotel 2024-07-17 17:10:36 +00:00
parent 650615c15d
commit 1458d81268
3 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/oxc_ast/src/generated/visit.rs
View file

@ -27,10 +27,14 @@ use walk::*;
/// Syntax tree traversal
pub trait Visit<'a>: Sized {
#[inline]
fn enter_node(&mut self, kind: AstKind<'a>) {}
#[inline]
fn leave_node(&mut self, kind: AstKind<'a>) {}
#[inline]
fn enter_scope(&mut self, flags: ScopeFlags, scope_id: &Cell<Option<ScopeId>>) {}
#[inline]
fn leave_scope(&mut self) {}
#[inline]

4
crates/oxc_ast/src/generated/visit_mut.rs
View file

@ -27,10 +27,14 @@ use walk_mut::*;
/// Syntax tree traversal
pub trait VisitMut<'a>: Sized {
#[inline]
fn enter_node(&mut self, kind: AstType) {}
#[inline]
fn leave_node(&mut self, kind: AstType) {}
#[inline]
fn enter_scope(&mut self, flags: ScopeFlags, scope_id: &Cell<Option<ScopeId>>) {}
#[inline]
fn leave_scope(&mut self) {}
#[inline]

4
tasks/ast_codegen/src/generators/visit.rs
View file

@ -122,12 +122,16 @@ fn generate_visit<const MUT: bool>(ctx: &CodegenCtx) -> TokenStream {
/// Syntax tree traversal
pub trait #trait_name <'a>: Sized {
#[inline]
fn enter_node(&mut self, kind: #ast_kind_type #ast_kind_life) {}
#[inline]
fn leave_node(&mut self, kind: #ast_kind_type #ast_kind_life) {}
endl!();
#[inline]
fn enter_scope(&mut self, flags: ScopeFlags, scope_id: &Cell<Option<ScopeId>>) {}
#[inline]
fn leave_scope(&mut self) {}
endl!();