dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 04:42:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(traverse): change generate_uid_in_based_on_node to accept a generic type parameter as node type (#6708)

Browse source 
Not only the `Expression` can be used to generate a binding name, but as long as AST that implements `GatherNodeParts` trait can do
This commit is contained in:
Dunqing 2024-10-21 03:03:32 +00:00
parent 1bcd707c8c
commit 1370c2da70
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_traverse/src/ast_operations/mod.rs
View file

@ -1,4 +1,4 @@
mod gather_node_parts; mod gather_node_parts;
pub use self::gather_node_parts::get_var_name_from_node; pub use self::gather_node_parts::{get_var_name_from_node, GatherNodeParts};
mod identifier; mod identifier;
pub use identifier::to_identifier; pub use identifier::to_identifier;

10
crates/oxc_traverse/src/context/mod.rs
View file

@ -13,7 +13,7 @@ use oxc_syntax::{
use crate::{ use crate::{
ancestor::{Ancestor, AncestorType}, ancestor::{Ancestor, AncestorType},
ast_operations::get_var_name_from_node, ast_operations::{get_var_name_from_node, GatherNodeParts},
}; };
mod ancestry; mod ancestry;
@ -352,9 +352,9 @@ impl<'a> TraverseCtx<'a> {
/// Based on Babel's `scope.generateUidBasedOnNode` logic. /// Based on Babel's `scope.generateUidBasedOnNode` logic.
/// <https://github.com/babel/babel/blob/419644f27c5c59deb19e71aaabd417a3bc5483ca/packages/babel-traverse/src/scope/index.ts#L543> /// <https://github.com/babel/babel/blob/419644f27c5c59deb19e71aaabd417a3bc5483ca/packages/babel-traverse/src/scope/index.ts#L543>
#[inline] #[inline]
pub fn generate_uid_based_on_node( pub fn generate_uid_based_on_node<N: GatherNodeParts<'a>>(
&mut self, &mut self,
node: &Expression<'a>, node: &N,
scope_id: ScopeId, scope_id: ScopeId,
flags: SymbolFlags, flags: SymbolFlags,
) -> BoundIdentifier<'a> { ) -> BoundIdentifier<'a> {
@ -367,9 +367,9 @@ impl<'a> TraverseCtx<'a> {
/// See also comments on [`TraverseScoping::generate_uid_name`] for important information /// See also comments on [`TraverseScoping::generate_uid_name`] for important information
/// on how UIDs are generated. There are some potential "gotchas". /// on how UIDs are generated. There are some potential "gotchas".
#[inline] #[inline]
pub fn generate_uid_in_current_scope_based_on_node( pub fn generate_uid_in_current_scope_based_on_node<N: GatherNodeParts<'a>>(
&mut self, &mut self,
node: &Expression<'a>, node: &N,
flags: SymbolFlags, flags: SymbolFlags,
) -> BoundIdentifier<'a> { ) -> BoundIdentifier<'a> {
self.generate_uid_based_on_node(node, self.current_scope_id(), flags) self.generate_uid_based_on_node(node, self.current_scope_id(), flags)