dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): false positives with setters in the getter-return rule. (#3714)

Browse source 
related but won't close #2312

[oxlint-ecosystem-ci](https://github.com/rzvxa/oxlint-ecosystem-ci/actions/runs/9547942249/job/26314030884)
This commit is contained in:
rzvxa 2024-06-19 14:45:06 +00:00
parent 4134de8dcf
commit 1190dee47f
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
crates/oxc_linter/src/rules/eslint/getter_return.rs
View file

@ -124,10 +124,13 @@ impl GetterReturn {
return true;
}
}
AstKind::ObjectProperty(ObjectProperty { kind, .. }) => {
AstKind::ObjectProperty(ObjectProperty { kind, key: prop_key, .. }) => {
if matches!(kind, PropertyKind::Get) {
return true;
}
if prop_key.name().is_some_and(|key| key != "get") {
return false;
}
if let Some(parent_2) = ctx.nodes().parent_node(parent.id()) {
if let Some(parent_3) = ctx.nodes().parent_node(parent_2.id()) {
@ -328,8 +331,11 @@ fn test() {
("class foo { get bar(){return;} }", Some(serde_json::json!([{ "allowImplicit": true }]))),
("Object.defineProperty(foo, \"bar\", { get: function () {return true;}});", None),
("Object.defineProperty(foo, \"bar\", { get: function () { ~function (){ return true; }();return true;}});", None),
("Object.defineProperty(foo, \"bar\", { set: function () {}});", None),
("Object.defineProperty(foo, \"bar\", { set: () => {}});", None),
("Object.defineProperties(foo, { bar: { get: function () {return true;}} });", None),
("Object.defineProperties(foo, { bar: { get: function () { ~function (){ return true; }(); return true;}} });", None),
("Object.defineProperties(foo, { bar: { set: function () {}} });", None),
("Reflect.defineProperty(foo, \"bar\", { get: function () {return true;}});", None),
("Reflect.defineProperty(foo, \"bar\", { get: function () { ~function (){ return true; }();return true;}});", None),
("Object.create(foo, { bar: { get() {return true;} } });", None),