dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): disable react/rules-of-hooks for vue and svelte files (#8165)

Browse source 
because of https://github.com/oxc-project/oxc/issues/8003

I used the FrameworkFlags in hope they are only active in `.vue` and
`.svelte` files.
This commit is contained in:
Alexander S. 2024-12-28 17:34:58 +01:00 committed by GitHub
parent 1b9a5bae2e
commit 1171e00a3c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
crates/oxc_linter/src/rules/react/rules_of_hooks.rs
View file

@ -16,7 +16,7 @@ use crate::{
context::LintContext, context::LintContext,
rule::Rule, rule::Rule,
utils::{is_react_component_or_hook_name, is_react_function_call, is_react_hook}, utils::{is_react_component_or_hook_name, is_react_function_call, is_react_hook},
AstNode, AstNode, FrameworkFlags,
}; };
mod diagnostics { mod diagnostics {
@ -99,7 +99,7 @@ pub struct RulesOfHooks;
declare_oxc_lint!( declare_oxc_lint!(
/// ### What it does /// ### What it does
/// ///
/// This enforcecs the Rules of Hooks /// This enforces the Rules of Hooks
/// ///
/// <https://reactjs.org/docs/hooks-rules.html> /// <https://reactjs.org/docs/hooks-rules.html>
/// ///
@ -108,6 +108,12 @@ declare_oxc_lint!(
); );
impl Rule for RulesOfHooks { impl Rule for RulesOfHooks {
fn should_run(&self, ctx: &crate::rules::ContextHost) -> bool {
// disable this rule in vue/nuxt and svelte(kit) files
// top level useFunction are very common
!ctx.frameworks().contains(FrameworkFlags::SvelteKit | FrameworkFlags::Nuxt)
}
fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) { fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
let AstKind::CallExpression(call) = node.kind() else { return }; let AstKind::CallExpression(call) = node.kind() else { return };