dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(rust): change RefCell.clone().into_inner() to RefCell.get()

Browse source
This commit is contained in:
Boshen 2023-10-16 11:22:32 +08:00
parent 952139c5ec
commit 110059ffb7
No known key found for this signature in database
GPG key ID: 234DA6A7079C6801
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/oxc_codegen/src/gen.rs
View file

@ -861,7 +861,7 @@ impl<'a, const MINIFY: bool> GenExpr<MINIFY> for Expression<'a> {
impl<const MINIFY: bool> Gen<MINIFY> for IdentifierReference {
fn gen(&self, p: &mut Codegen<{ MINIFY }>, _ctx: Context) {
// if let Some(mangler) = &p.mangler {
// if let Some(reference_id) = self.reference_id.clone().into_inner() {
// if let Some(reference_id) = self.reference_id.get() {
// if let Some(name) = mangler.get_reference_name(reference_id) {
// p.print_str(name.clone().as_bytes());
// return;
@ -880,7 +880,7 @@ impl<const MINIFY: bool> Gen<MINIFY> for IdentifierName {
impl<const MINIFY: bool> Gen<MINIFY> for BindingIdentifier {
fn gen(&self, p: &mut Codegen<{ MINIFY }>, _ctx: Context) {
p.print_symbol(self.symbol_id.clone().into_inner(), &self.name);
p.print_symbol(self.symbol_id.get(), &self.name);
}
}

2
crates/oxc_minifier/src/compressor/fold.rs
View file

@ -740,7 +740,7 @@ impl<'a> Compressor<'a> {
let ident = IdentifierReference {
span: unary_expr.span,
name: ident.name.clone(),
reference_id: ident.reference_id.clone().into_inner().into(),
reference_id: ident.reference_id.clone(),
reference_flag: ident.reference_flag,
};
return Some(self.ast.identifier_reference_expression(ident));

4
crates/oxc_minifier/src/compressor/mod.rs
View file

@ -166,7 +166,7 @@ impl<'a> Compressor<'a> {
fn compress_undefined(&mut self, expr: &mut Expression<'a>) -> bool {
let Expression::Identifier(ident) = expr else { return false };
if ident.name == "undefined" {
// if let Some(reference_id) = ident.reference_id.clone().into_inner() {
// if let Some(reference_id) = ident.reference_id.get() {
// && self.semantic.symbols().is_global_reference(reference_id)
*expr = self.create_void_0();
return true;
@ -180,7 +180,7 @@ impl<'a> Compressor<'a> {
fn compress_infinity(&mut self, expr: &mut Expression<'a>) -> bool {
let Expression::Identifier(ident) = expr else { return false };
if ident.name == "Infinity" {
// if let Some(reference_id) = ident.reference_id.clone().into_inner() {
// if let Some(reference_id) = ident.reference_id.get() {
//&& self.semantic.symbols().is_global_reference(reference_id)
*expr = self.create_one_div_zero();
return true;