dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): fix false positive for erasing-op in 0/0 case (#2009)

Browse source
This commit is contained in:
Cameron 2024-01-13 02:32:26 +00:00 committed by GitHub
parent 712e99cf9b
commit 107a32ea48
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
crates/oxc_linter/src/rules/oxc/erasing_op.rs
View file

@ -58,6 +58,9 @@ impl Rule for ErasingOp {
check_op(binary_expression, &binary_expression.right, ctx); check_op(binary_expression, &binary_expression.right, ctx);
} }
BinaryOperator::Division => { BinaryOperator::Division => {
if is_number_value(&binary_expression.right, 0.0) {
return;
}
check_op(binary_expression, &binary_expression.left, ctx); check_op(binary_expression, &binary_expression.left, ctx);
} }
_ => (), _ => (),
@ -66,7 +69,7 @@ impl Rule for ErasingOp {
} }
fn is_number_value(expr: &Expression, value: f64) -> bool { fn is_number_value(expr: &Expression, value: f64) -> bool {
if let Expression::NumberLiteral(number_literal) = expr { if let Expression::NumberLiteral(number_literal) = expr.without_parenthesized() {
(number_literal.value - value).abs() < f64::EPSILON (number_literal.value - value).abs() < f64::EPSILON
} else { } else {
false false
@ -87,7 +90,7 @@ fn check_op<'a, 'b>(
fn test() { fn test() {
use crate::tester::Tester; use crate::tester::Tester;
let pass = vec!["x * 1;", "1 * x;", "5 & x;", "x / 1;", "1 / x;"]; let pass = vec!["x * 1;", "1 * x;", "5 & x;", "x / 1;", "1 / x;", "0 / 0"];
let fail = vec!["x * 0;", "0 * x;", "0 & x;", "0 / x;"]; let fail = vec!["x * 0;", "0 * x;", "0 & x;", "0 / x;"];