dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(linter): optimize no-dupe-keys (#4292)

Browse source 
This tweaks the `no-dupe-keys` lint in order to try to optimize it.
The lints reliably shows up in both CPU and memory profiling,
due to the cost of allocating/growing the hashmap and hashing into it.
This PR tries to tackle both by skipping trivial cases and by
pre-allocating a larger hashmap.
This commit is contained in:
lucab 2024-07-16 11:08:23 +00:00
parent c5731a5431
commit 0fdc88beee
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
crates/oxc_linter/src/rules/eslint/no_dupe_keys.rs
View file

@ -5,7 +5,7 @@ use oxc_ast::{
use oxc_diagnostics::OxcDiagnostic; use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint; use oxc_macros::declare_oxc_lint;
use oxc_span::{GetSpan, Span}; use oxc_span::{GetSpan, Span};
use rustc_hash::FxHashMap; use rustc_hash::{FxBuildHasher, FxHashMap};
use crate::{context::LintContext, rule::Rule, AstNode}; use crate::{context::LintContext, rule::Rule, AstNode};
@ -43,7 +43,11 @@ impl Rule for NoDupeKeys {
let AstKind::ObjectExpression(obj_expr) = node.kind() else { let AstKind::ObjectExpression(obj_expr) = node.kind() else {
return; return;
}; };
let mut map = FxHashMap::default(); let len = obj_expr.properties.len();
if len <= 1 {
return;
}
let mut map = FxHashMap::with_capacity_and_hasher(len, FxBuildHasher);
for prop in &obj_expr.properties { for prop in &obj_expr.properties {
let ObjectPropertyKind::ObjectProperty(prop) = prop else { let ObjectPropertyKind::ObjectProperty(prop) = prop else {
continue; continue;