dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-22 21:58:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(isolated-declarations): should be added to references, not bindings (#3726)

Browse source
This commit is contained in:
Dunqing 2024-06-17 16:47:02 +00:00
parent 8f64d9992f
commit 0fbecdcd81
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/oxc_isolated_declarations/src/scope.rs
View file

@ -133,8 +133,8 @@ impl<'a> Visit<'a> for ScopeTree<'a> {
fn visit_export_default_declaration(&mut self, decl: &ExportDefaultDeclaration<'a>) { fn visit_export_default_declaration(&mut self, decl: &ExportDefaultDeclaration<'a>) {
if let ExportDefaultDeclarationKind::Identifier(ident) = &decl.declaration { if let ExportDefaultDeclarationKind::Identifier(ident) = &decl.declaration {
self.add_type_binding(&ident.name); self.add_type_reference(&ident.name);
self.add_value_binding(&ident.name); self.add_value_reference(&ident.name);
} else { } else {
walk_export_default_declaration(self, decl); walk_export_default_declaration(self, decl);
} }

3
tasks/coverage/transpile.snap
View file

@ -2,7 +2,7 @@ commit: d8086f14
transpile Summary: transpile Summary:
AST Parsed : 20/20 (100.00%) AST Parsed : 20/20 (100.00%)
Positive Passed: 8/20 (40.00%) Positive Passed: 9/20 (45.00%)
Mismatch: "declarationAsyncAndGeneratorFunctions.ts" Mismatch: "declarationAsyncAndGeneratorFunctions.ts"
Mismatch: "declarationBasicSyntax.ts" Mismatch: "declarationBasicSyntax.ts"
Mismatch: "declarationComputedPropertyNames.ts" Mismatch: "declarationComputedPropertyNames.ts"
@ -14,4 +14,3 @@ Mismatch: "declarationPartialNodeReuseTypeOf.ts"
Mismatch: "declarationRestParameters.ts" Mismatch: "declarationRestParameters.ts"
Mismatch: "declarationSingleFileHasErrors.ts" Mismatch: "declarationSingleFileHasErrors.ts"
Mismatch: "declarationSingleFileHasErrorsReported.ts" Mismatch: "declarationSingleFileHasErrorsReported.ts"
Mismatch: "declarationsSimple.ts"