dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 20:32:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(ast): change plain_function to accept FunctionBody as a required parameter (#6709)

Browse source 
The `plain_function` method is used to construct js-only AST, and the `FunctionBody` is never empty in js
This commit is contained in:
Dunqing 2024-10-21 03:03:32 +00:00
parent 1370c2da70
commit 0e9b695634
2 changed files with 16 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
crates/oxc_ast/src/ast_builder_impl.rs
View file

@ -176,11 +176,21 @@ impl<'a> AstBuilder<'a> {
span: Span,
id: Option<BindingIdentifier<'a>>,
params: FormalParameters<'a>,
body: Option<FunctionBody<'a>>,
body: FunctionBody<'a>,
) -> Box<'a, Function<'a>> {
self.alloc(
self.function(r#type, span, id, false, false, false, NONE, NONE, params, NONE, body),
)
self.alloc(self.function(
r#type,
span,
id,
false,
false,
false,
NONE,
NONE,
params,
NONE,
Some(body),
))
}
/* ---------- Modules ---------- */

9
crates/oxc_transformer/src/typescript/namespace.rs
View file

@ -336,13 +336,8 @@ impl<'a, 'ctx> TypeScriptNamespace<'a, 'ctx> {
let items = ctx.ast.vec1(ctx.ast.plain_formal_parameter(SPAN, pattern));
ctx.ast.formal_parameters(SPAN, FormalParameterKind::FormalParameter, items, NONE)
};
let function = ctx.ast.plain_function(
FunctionType::FunctionExpression,
SPAN,
None,
params,
Some(body),
);
let function =
ctx.ast.plain_function(FunctionType::FunctionExpression, SPAN, None, params, body);
function.scope_id.set(Some(scope_id));
*ctx.scopes_mut().get_flags_mut(scope_id) =
ScopeFlags::Function | ScopeFlags::StrictMode;