dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(transformer/react-refresh): reserve capacity in hook key string (#8016)

Browse source 
Follow-on after #8013. Reserve sufficient capacity in `String` used to store hook key, before pushing to it.

Also refactor so code for constructing key is only included once.
This commit is contained in:
overlookmotel 2024-12-19 17:46:29 +00:00
parent 69b1ef3c16
commit 0deb9e6c2e
1 changed files with 28 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

52
crates/oxc_transformer/src/jsx/refresh.rs
View file

@ -372,38 +372,42 @@ impl<'a, 'ctx> Traverse<'a> for ReactRefresh<'a, 'ctx> {
};
let args = &call_expr.arguments;
let args_key = if hook_name == "useState" && args.len() > 0 {
args[0].span().source_text(self.ctx.source_text)
let (args_key, mut key_len) = if hook_name == "useState" && !args.is_empty() {
let args_key = args[0].span().source_text(self.ctx.source_text);
(args_key, args_key.len() + 4)
} else if hook_name == "useReducer" && args.len() > 1 {
args[1].span().source_text(self.ctx.source_text)
let args_key = args[1].span().source_text(self.ctx.source_text);
(args_key, args_key.len() + 4)
} else {
""
("", 2)
};
let is_empty = args_key.is_empty();
// `hook_name{{declarator_id(args_key)}}` or `hook_name{{declarator_id}}`
let push_key_to_string = |string: &mut String| {
string.push_str(hook_name.as_str());
string.push('{');
string.push_str(declarator_id);
string.push_str(if is_empty { "" } else { "(" });
string.push_str(args_key);
string.push_str(if is_empty { "" } else { ")" });
string.push('}');
};
key_len += hook_name.len() + declarator_id.len();
match self.function_signature_keys.entry(current_scope_id) {
Entry::Occupied(mut entry) => {
let string = entry.get_mut();
let string = match self.function_signature_keys.entry(current_scope_id) {
Entry::Occupied(entry) => {
let string = entry.into_mut();
string.reserve(key_len + 2);
string.push_str("\\n");
push_key_to_string(string);
}
Entry::Vacant(entry) => {
let mut string = String::new();
push_key_to_string(&mut string);
entry.insert(string);
string
}
Entry::Vacant(entry) => entry.insert(String::with_capacity(key_len)),
};
// `hook_name{{declarator_id(args_key)}}` or `hook_name{{declarator_id}}`
let old_len = string.len();
string.push_str(&hook_name);
string.push('{');
string.push_str(declarator_id);
if !args_key.is_empty() {
string.push('(');
string.push_str(args_key);
string.push(')');
}
string.push('}');
debug_assert_eq!(key_len, string.len() - old_len);
}
}