dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(ast): AstBuilder enum builder methods use alloc_* methods (#8281)

Browse source 
Pure refactor. `AstBuilder` methods can use `alloc_*` methods directly, instead of calling `alloc`. Probably this makes no difference to performance as all these methods are marked `#[inline]` anyway. But in general it's better to use methods which don't return large objects on the stack.
This commit is contained in:
overlookmotel 2025-01-06 15:09:04 +00:00
parent 5106088b88
commit 0db2a22e48
2 changed files with 265 additions and 316 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

567
crates/oxc_ast/src/generated/ast_builder.rs
View file

File diff suppressed because it is too large Load diff

14
tasks/ast_tools/src/generators/ast_builder.rs
View file

@ -131,21 +131,21 @@ fn generate_enum_variant_builder_fn(
.or_else(|| var_type.transparent_type_id())
.and_then(|id| schema.get(id))
.expect("type not found!");
let (params, inner_builder) = match ty {
let (params, mut inner_builder) = match ty {
TypeDef::Struct(it) => (get_struct_params(it, schema), struct_builder_name(it)),
TypeDef::Enum(_) => panic!("Unsupported!"),
};
let does_alloc = matches!(var_type_name, TypeName::Box(_));
if does_alloc {
inner_builder = format_ident!("alloc_{inner_builder}");
}
let params = params.into_iter().filter(Param::not_default).collect_vec();
let fields = params.iter().map(|it| it.ident.clone());
let (generic_params, where_clause) = get_generic_params(&params);
let mut inner = quote!(self.#inner_builder(#(#fields),*));
let mut does_alloc = false;
if matches!(var_type_name, TypeName::Box(_)) {
inner = quote!(self.alloc(#inner));
does_alloc = true;
}
let inner = quote!(self.#inner_builder(#(#fields),*));
let article = article_for(enum_ident.to_string());
let mut docs = DocComment::new(format!(" Build {article} [`{enum_ident}::{var_ident}`]"))