dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): invalid binary expression with overflow (#4647)

Browse source 
Closes #4628

Also fixes an identical bug in `<<`
This commit is contained in:
DonIsaac 2024-08-05 05:02:28 +00:00
parent 0fba73897c
commit 06aec77dfd
1 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
crates/oxc_linter/src/utils/tree_shaking.rs
View file

@ -421,7 +421,11 @@ pub fn calculate_binary_operation(op: BinaryOperator, left: Value, right: Value)
BinaryOperator::ShiftRightZeroFill => match (left, right) {
(Value::Number(a), Value::Number(b)) => {
Value::Number(f64::from((a as u32) >> (b as u32)))
if b >= a {
Value::Number(0.0)
} else {
Value::Number(f64::from((a as u32) >> (b as u32)))
}
}
_ => Value::Unknown,
},
@ -447,7 +451,12 @@ pub fn calculate_binary_operation(op: BinaryOperator, left: Value, right: Value)
},
BinaryOperator::ShiftLeft => match (left, right) {
(Value::Number(a), Value::Number(b)) => {
Value::Number(f64::from((a as i32) << (b as i32)))
// NOTE: could overflow, in which case node produces `a`
if b >= 32.0 {
Value::Number(a)
} else {
Value::Number(f64::from((a as i32) << (b as i32)))
}
}
_ => Value::Unknown,
},
@ -589,7 +598,10 @@ fn test_calculate_binary_operation() {
// "<<",
let op = BinaryOperator::ShiftLeft;
assert_eq!(fun(op, Value::Number(1.0), Value::Number(0.0),), Value::Number(1.0));
assert_eq!(fun(op, Value::Number(1.0), Value::Number(2.0),), Value::Number(4.0));
assert_eq!(fun(op, Value::Number(1.0), Value::Number(31.0),), Value::Number(-2_147_483_648.0));
assert_eq!(fun(op, Value::Number(1.0), Value::Number(f64::MAX),), Value::Number(1.0));
// ">>",
let op = BinaryOperator::ShiftRight;
@ -597,7 +609,11 @@ fn test_calculate_binary_operation() {
// ">>>",
let op = BinaryOperator::ShiftRightZeroFill;
assert_eq!(fun(op, Value::Number(0.0), Value::Number(0.0),), Value::Number(0.0));
assert_eq!(fun(op, Value::Number(1.0), Value::Number(0.0),), Value::Number(1.0));
assert_eq!(fun(op, Value::Number(4.0), Value::Number(2.0),), Value::Number(1.0));
assert_eq!(fun(op, Value::Number(2.0), Value::Number(4.0),), Value::Number(0.0));
assert_eq!(fun(op, Value::Number(4096.0), Value::Number(4096.0)), Value::Number(0.0));
// "%",
let op = BinaryOperator::Remainder;