dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(ast)!: remove ExportDefaultDeclarationKind::TSEnumDeclaration (#3666)

Browse source 
TypeScript doesn't support `export default enum id {}`


https://www.typescriptlang.org/play/?target=2&isolatedDeclarations=true&emitDeclarationOnly=true&isolatedModules=false&ts=5.5.1-rc#code/KYDwDg9gTgLgBAE2AMwIYFcA29gDt0C2cAlgnAN4C+QA

https://github.com/microsoft/TypeScript/issues/3320
This commit is contained in:
Dunqing 2024-06-14 14:40:37 +08:00 committed by GitHub
parent e148a32ce3
commit 0578ece6a4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 3 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
crates/oxc_ast/src/ast/js.rs
View file

@ -3315,7 +3315,6 @@ pub enum ExportDefaultDeclarationKind<'a> {
ClassDeclaration(Box<'a, Class<'a>>) = 65,
TSInterfaceDeclaration(Box<'a, TSInterfaceDeclaration<'a>>) = 66,
TSEnumDeclaration(Box<'a, TSEnumDeclaration<'a>>) = 67,
// `Expression` variants added here by `inherit_variants!` macro
@inherit Expression
@ -3328,7 +3327,7 @@ impl<'a> ExportDefaultDeclarationKind<'a> {
match self {
Self::FunctionDeclaration(func) => func.is_typescript_syntax(),
Self::ClassDeclaration(class) => class.is_typescript_syntax(),
Self::TSInterfaceDeclaration(_) | Self::TSEnumDeclaration(_) => true,
Self::TSInterfaceDeclaration(_) => true,
_ => false,
}
}

1
crates/oxc_ast/src/span.rs
View file

@ -565,7 +565,6 @@ impl<'a> GetSpan for ExportDefaultDeclarationKind<'a> {
match self {
Self::ClassDeclaration(x) => x.span,
Self::FunctionDeclaration(x) => x.span,
Self::TSEnumDeclaration(x) => x.span,
Self::TSInterfaceDeclaration(x) => x.span,
// `Expression`
Self::BooleanLiteral(e) => e.span,

1
crates/oxc_codegen/src/gen.rs
View file

@ -991,7 +991,6 @@ impl<'a, const MINIFY: bool> Gen<MINIFY> for ExportDefaultDeclarationKind<'a> {
p.print_soft_newline();
}
Self::TSInterfaceDeclaration(interface) => interface.gen(p, ctx),
Self::TSEnumDeclaration(enum_decl) => enum_decl.gen(p, ctx),
}
}
}

1
crates/oxc_prettier/src/format/mod.rs
View file

@ -1233,7 +1233,6 @@ impl<'a> Format<'a> for ExportDefaultDeclarationKind<'a> {
Self::FunctionDeclaration(decl) => decl.format(p),
Self::ClassDeclaration(decl) => decl.format(p),
Self::TSInterfaceDeclaration(decl) => decl.format(p),
Self::TSEnumDeclaration(decl) => decl.format(p),
}
}
}

3
crates/oxc_prettier/src/format/module.rs
View file

@ -60,8 +60,7 @@ fn print_semicolon_after_export_declaration<'a>(
match_expression!(ExportDefaultDeclarationKind) => Some(ss!(";")),
ExportDefaultDeclarationKind::FunctionDeclaration(_)
| ExportDefaultDeclarationKind::ClassDeclaration(_)
| ExportDefaultDeclarationKind::TSInterfaceDeclaration(_)
| ExportDefaultDeclarationKind::TSEnumDeclaration(_) => None,
| ExportDefaultDeclarationKind::TSInterfaceDeclaration(_) => None,
},
ModuleDeclaration::ExportAllDeclaration(_)
| ModuleDeclaration::ExportNamedDeclaration(_)

3
crates/oxc_semantic/src/module_record/builder.rs
View file

@ -249,8 +249,7 @@ impl ModuleRecordBuilder {
match_expression!(ExportDefaultDeclarationKind) => None,
ExportDefaultDeclarationKind::FunctionDeclaration(func) => func.id.as_ref(),
ExportDefaultDeclarationKind::ClassDeclaration(class) => class.id.as_ref(),
ExportDefaultDeclarationKind::TSInterfaceDeclaration(_)
| ExportDefaultDeclarationKind::TSEnumDeclaration(_) => return,
ExportDefaultDeclarationKind::TSInterfaceDeclaration(_) => return,
};
let export_entry = ExportEntry {
export_name: ExportExportName::Default(exported_name.span()),

3
crates/oxc_traverse/src/walk.rs
View file

@ -3054,9 +3054,6 @@ pub(crate) unsafe fn walk_export_default_declaration_kind<'a, Tr: Traverse<'a>>(
ExportDefaultDeclarationKind::TSInterfaceDeclaration(node) => {
walk_ts_interface_declaration(traverser, (&mut **node) as *mut _, ctx)
}
ExportDefaultDeclarationKind::TSEnumDeclaration(node) => {
walk_ts_enum_declaration(traverser, (&mut **node) as *mut _, ctx)
}
ExportDefaultDeclarationKind::BooleanLiteral(_)
| ExportDefaultDeclarationKind::NullLiteral(_)
| ExportDefaultDeclarationKind::NumericLiteral(_)