dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore(linter) move bad_bitwise_operator to restriction category

Browse source 
closes #243
This commit is contained in:
Boshen 2023-04-05 14:29:32 +08:00
parent 6e356788b3
commit 043a751dc7
No known key found for this signature in database
GPG key ID: 9C7A8C8AB22BEBD1
2 changed files with 15 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
crates/oxc_linter/src/rules/deepscan/bad_bitwise_operator.rs
View file

@ -1,5 +1,5 @@
use oxc_ast::{
ast::{AssignmentOperator, BinaryOperator, Expression, UnaryOperator, BinaryExpression},
ast::{AssignmentOperator, BinaryExpression, BinaryOperator, Expression, UnaryOperator},
AstKind, Span,
};
use oxc_diagnostics::{
@ -56,7 +56,8 @@ declare_oxc_lint!(
/// input |= '';
/// ```
BadBitwiseOperator,
correctness
restriction // Restricted because there are false positives for enum bitflags in TypeScript,
// e.g. in the vscode repo
);
impl Rule for BadBitwiseOperator {
@ -70,7 +71,9 @@ impl Rule for BadBitwiseOperator {
}
}
AstKind::AssignmentExpression(assign_expr) => {
if assign_expr.operator == AssignmentOperator::BitwiseOR && !is_numeric_expr(&assign_expr.right, true) {
if assign_expr.operator == AssignmentOperator::BitwiseOR
&& !is_numeric_expr(&assign_expr.right, true)
{
ctx.diagnostic(BadBitwiseOrOperatorDiagnostic(assign_expr.span));
}
}
@ -107,7 +110,7 @@ fn is_mistype_option_fallback(node: &AstNode) -> bool {
return false;
}
if let Expression::Identifier(_) = &binary_expr.left
if let Expression::Identifier(_) = &binary_expr.left
&& !is_numeric_expr(&binary_expr.right, true) {
return true
}
@ -137,26 +140,26 @@ fn is_numeric_expr(expr: &Expression, is_outer_most: bool) -> bool {
}
_ => {
if is_outer_most {
expr.is_undefined()
expr.is_undefined()
} else {
!expr.is_string_literal()
!expr.is_string_literal()
}
}
}
}
fn is_string_concat(binary_expr: &BinaryExpression) -> bool {
binary_expr.operator == BinaryOperator::Addition && (
contains_string_literal(&binary_expr.left) || contains_string_literal(&binary_expr.right)
)
binary_expr.operator == BinaryOperator::Addition
&& (contains_string_literal(&binary_expr.left)
|| contains_string_literal(&binary_expr.right))
}
fn contains_string_literal(expr: &Expression) -> bool {
match expr {
Expression::StringLiteral(_) => true,
Expression::UnaryExpression(unary_expr) => unary_expr.operator == UnaryOperator::Typeof,
Expression::BinaryExpression(binary_expr) => is_string_concat(binary_expr),
Expression::BinaryExpression(binary_expr) => is_string_concat(binary_expr),
Expression::ParenthesizedExpression(paren_expr) => {
contains_string_literal(&paren_expr.expression)
}

1
crates/oxc_macros/src/declare_oxc_lint.rs
View file

@ -58,6 +58,7 @@ pub fn declare_oxc_lint(metadata: LintRuleMeta) -> TokenStream {
let canonical_name = name.to_string().to_case(Case::Kebab);
let category = match category.to_string().as_str() {
"correctness" => quote! { RuleCategory::Correctness },
"restriction" => quote! { RuleCategory::Restriction },
"nursery" => quote! { RuleCategory::Nursery },
_ => panic!("invalid rule category"),
};