dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(lexer): make handle_byte a method of Lexer (#8291)

Browse source 
Pure refactor. `handle_byte` was a free function. Make it a method of `Lexer` instead - more idiomatic.
This commit is contained in:
overlookmotel 2025-01-07 06:58:22 +00:00
parent 922c5147b5
commit 0344e98c99
2 changed files with 12 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
crates/oxc_parser/src/lexer/byte_handlers.rs
View file

@ -2,15 +2,17 @@ use crate::diagnostics;
use super::{Kind, Lexer};
/// Handle next byte of source.
///
/// # SAFETY
///
/// * Lexer must not be at end of file.
/// * `byte` must be next byte of source code, corresponding to current position of `lexer.source`.
/// * Only `BYTE_HANDLERS` for ASCII characters may use the `ascii_byte_handler!()` macro.
pub(super) unsafe fn handle_byte(byte: u8, lexer: &mut Lexer) -> Kind {
BYTE_HANDLERS[byte as usize](lexer)
impl Lexer<'_> {
/// Handle next byte of source.
///
/// # SAFETY
///
/// * Lexer must not be at end of file.
/// * `byte` must be next byte of source code, corresponding to current position of `lexer.source`.
/// * Only `BYTE_HANDLERS` for ASCII characters may use the `ascii_byte_handler!()` macro.
pub(super) unsafe fn handle_byte(&mut self, byte: u8) -> Kind {
BYTE_HANDLERS[byte as usize](self)
}
}
type ByteHandler = unsafe fn(&mut Lexer<'_>) -> Kind;

3
crates/oxc_parser/src/lexer/mod.rs
View file

@ -39,7 +39,6 @@ pub use kind::Kind;
pub use number::{parse_big_int, parse_float, parse_int};
pub use token::Token;
use byte_handlers::handle_byte;
use source::{Source, SourcePosition};
use trivia_builder::TriviaBuilder;
@ -315,7 +314,7 @@ impl<'a> Lexer<'a> {
};
// SAFETY: `byte` is byte value at current position in source
let kind = unsafe { handle_byte(byte, self) };
let kind = unsafe { self.handle_byte(byte) };
if kind != Kind::Skip {
return kind;
}