From 0297cf7cc707781fb7147c131bc68e8c2afab1af Mon Sep 17 00:00:00 2001 From: Dunqing Date: Tue, 14 Nov 2023 09:36:37 +0800 Subject: [PATCH] fix(prettier): remove redundant newline and semicolons from the Program (#1284) --- crates/oxc_prettier/src/format.rs | 4 +--- tasks/prettier_conformance/prettier.snap.md | 3 ++- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/crates/oxc_prettier/src/format.rs b/crates/oxc_prettier/src/format.rs index bcc9989be..532168c4d 100644 --- a/crates/oxc_prettier/src/format.rs +++ b/crates/oxc_prettier/src/format.rs @@ -10,7 +10,7 @@ use oxc_allocator::{Box, Vec}; use oxc_ast::ast::*; use oxc_syntax::operator::{BinaryOperator, UnaryOperator}; -use crate::{array, doc::Doc, format, group, hardline, indent, softline, string, Prettier}; +use crate::{array, doc::Doc, format, group, indent, softline, string, Prettier}; pub trait Format<'a> { #[must_use] @@ -30,8 +30,6 @@ impl<'a> Format<'a> for Program<'a> { fn format(&self, p: &mut Prettier<'a>) -> Doc<'a> { let mut parts = p.vec(); parts.extend(self.body.iter().map(|stmt| stmt.format(p))); - parts.push(string!(p, ";")); - parts.push(hardline!()); Doc::Array(parts) } } diff --git a/tasks/prettier_conformance/prettier.snap.md b/tasks/prettier_conformance/prettier.snap.md index 04feb9f61..2271ed013 100644 --- a/tasks/prettier_conformance/prettier.snap.md +++ b/tasks/prettier_conformance/prettier.snap.md @@ -1,4 +1,4 @@ -Compatibility: 1/173 (0.01%) +Compatibility: 0/173 (0.00%) # Failed @@ -11,6 +11,7 @@ Compatibility: 1/173 (0.01%) * arrows-bind * assignment * assignment-comments +* assignment-expression * async * async-do-expressions * babel-plugins