dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-22 21:58:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(linter/eslint): show ignore patterns in eslint/no-unused-vars diagnostic messages (#6696)

Browse source 
Inform users what pattern an unused variable must match in diagnostic help messages.

```
  ⚠ eslint(no-unused-vars): Variable 'a' is declared but never used. Unused variables should start with a '_'.
   ╭─[no_unused_vars.tsx:1:5]
 1 │ var a=10
   ·     ┬
   ·     ╰── 'a' is declared here
   ╰────
  help: Consider removing this declaration.
```
This commit is contained in:
DonIsaac 2024-10-20 04:24:53 +00:00
parent e9976d46d4
commit 01a35bb446
16 changed files with 266 additions and 209 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

86
crates/oxc_linter/src/rules/eslint/no_unused_vars/diagnostic.rs
View file

@ -1,61 +1,95 @@
use std::fmt;
use cow_utils::CowUtils; use cow_utils::CowUtils;
use oxc_diagnostics::OxcDiagnostic; use oxc_diagnostics::OxcDiagnostic;
use oxc_semantic::SymbolFlags; use oxc_semantic::SymbolFlags;
use oxc_span::{GetSpan, Span}; use oxc_span::{GetSpan, Span};
use super::Symbol; use super::{options::IgnorePattern, Symbol};
fn pronoun_for_symbol(symbol_flags: SymbolFlags) -> &'static str { fn pronoun_for_symbol(
symbol_flags: SymbolFlags,
) -> (/* singular */ &'static str, /* plural */ &'static str) {
if symbol_flags.is_function() { if symbol_flags.is_function() {
"Function" ("Function", "functions")
} else if symbol_flags.is_class() { } else if symbol_flags.is_class() {
"Class" ("Class", "classes")
} else if symbol_flags.is_interface() { } else if symbol_flags.is_interface() {
"Interface" ("Interface", "interfaces")
} else if symbol_flags.is_type_alias() { } else if symbol_flags.is_type_alias() {
"Type alias" ("Type alias", "type aliases")
} else if symbol_flags.is_enum() { } else if symbol_flags.is_enum() {
"Enum" ("Enum", "enums")
} else if symbol_flags.is_enum_member() { } else if symbol_flags.is_enum_member() {
"Enum member" ("Enum member", "enum members")
} else if symbol_flags.is_type_import() { } else if symbol_flags.is_type_import() {
"Type" ("Type", "types")
} else if symbol_flags.is_import() { } else if symbol_flags.is_import() {
"Identifier" ("Identifier", "identifiers")
} else if symbol_flags.is_catch_variable() {
("Catch parameter", "caught errors")
} else { } else {
"Variable" ("Variable", "variables")
} }
} }
pub fn used_ignored(symbol: &Symbol<'_, '_>) -> OxcDiagnostic { pub fn used_ignored<R>(symbol: &Symbol<'_, '_>, pat: &IgnorePattern<R>) -> OxcDiagnostic
let pronoun = pronoun_for_symbol(symbol.flags()); where
R: fmt::Display,
{
let (pronoun_singular, _) = pronoun_for_symbol(symbol.flags());
let name = symbol.name(); let name = symbol.name();
OxcDiagnostic::warn(format!("{pronoun} '{name}' is marked as ignored but is used.")) let help_suffix = match pat {
IgnorePattern::None => ".".into(),
IgnorePattern::Default => {
name.strip_prefix('_').map_or(".".into(), |name| format!(" to '{name}'."))
}
IgnorePattern::Some(ref r) => {
format!(" to match the pattern /{r}/.")
}
};
OxcDiagnostic::warn(format!("{pronoun_singular} '{name}' is marked as ignored but is used."))
.with_label(symbol.span().label(format!("'{name}' is declared here"))) .with_label(symbol.span().label(format!("'{name}' is declared here")))
.with_help(format!("Consider renaming this {}.", pronoun.cow_to_lowercase())) .with_help(format!(
"Consider renaming this {}{help_suffix}",
pronoun_singular.cow_to_lowercase()
))
} }
/// Variable 'x' is declared but never used. /// Variable 'x' is declared but never used.
pub fn declared(symbol: &Symbol<'_, '_>) -> OxcDiagnostic { pub fn declared<R>(symbol: &Symbol<'_, '_>, pat: &IgnorePattern<R>) -> OxcDiagnostic
where
R: fmt::Display,
{
let (verb, help) = if symbol.flags().is_catch_variable() { let (verb, help) = if symbol.flags().is_catch_variable() {
("caught", "Consider handling this error.") ("caught", "Consider handling this error.")
} else { } else {
("declared", "Consider removing this declaration.") ("declared", "Consider removing this declaration.")
}; };
let pronoun = pronoun_for_symbol(symbol.flags());
let name = symbol.name(); let name = symbol.name();
let (pronoun, pronoun_plural) = pronoun_for_symbol(symbol.flags());
let suffix = pat.diagnostic_help(pronoun_plural);
OxcDiagnostic::warn(format!("{pronoun} '{name}' is {verb} but never used.")) OxcDiagnostic::warn(format!("{pronoun} '{name}' is {verb} but never used.{suffix}"))
.with_label(symbol.span().label(format!("'{name}' is declared here"))) .with_label(symbol.span().label(format!("'{name}' is declared here")))
.with_help(help) .with_help(help)
} }
/// Variable 'x' is assigned a value but never used. /// Variable 'x' is assigned a value but never used.
pub fn assign(symbol: &Symbol<'_, '_>, assign_span: Span) -> OxcDiagnostic { pub fn assign<R>(
let pronoun = pronoun_for_symbol(symbol.flags()); symbol: &Symbol<'_, '_>,
assign_span: Span,
pat: &IgnorePattern<R>,
) -> OxcDiagnostic
where
R: fmt::Display,
{
let name = symbol.name(); let name = symbol.name();
let (pronoun, pronoun_plural) = pronoun_for_symbol(symbol.flags());
let suffix = pat.diagnostic_help(pronoun_plural);
OxcDiagnostic::warn(format!("{pronoun} '{name}' is assigned a value but never used.")) OxcDiagnostic::warn(format!("{pronoun} '{name}' is assigned a value but never used.{suffix}"))
.with_labels([ .with_labels([
symbol.span().label(format!("'{name}' is declared here")), symbol.span().label(format!("'{name}' is declared here")),
assign_span.label("it was last assigned here"), assign_span.label("it was last assigned here"),
@ -64,17 +98,21 @@ pub fn assign(symbol: &Symbol<'_, '_>, assign_span: Span) -> OxcDiagnostic {
} }
/// Parameter 'x' is declared but never used. /// Parameter 'x' is declared but never used.
pub fn param(symbol: &Symbol<'_, '_>) -> OxcDiagnostic { pub fn param<R>(symbol: &Symbol<'_, '_>, pat: &IgnorePattern<R>) -> OxcDiagnostic
where
R: fmt::Display,
{
let name = symbol.name(); let name = symbol.name();
let suffix = pat.diagnostic_help("parameters");
OxcDiagnostic::warn(format!("Parameter '{name}' is declared but never used.")) OxcDiagnostic::warn(format!("Parameter '{name}' is declared but never used.{suffix}"))
.with_label(symbol.span().label(format!("'{name}' is declared here"))) .with_label(symbol.span().label(format!("'{name}' is declared here")))
.with_help("Consider removing this parameter.") .with_help("Consider removing this parameter.")
} }
/// Identifier 'x' imported but never used. /// Identifier 'x' imported but never used.
pub fn imported(symbol: &Symbol<'_, '_>) -> OxcDiagnostic { pub fn imported(symbol: &Symbol<'_, '_>) -> OxcDiagnostic {
let pronoun = pronoun_for_symbol(symbol.flags()); let (pronoun, _) = pronoun_for_symbol(symbol.flags());
let name = symbol.name(); let name = symbol.name();
OxcDiagnostic::warn(format!("{pronoun} '{name}' is imported but never used.")) OxcDiagnostic::warn(format!("{pronoun} '{name}' is imported but never used."))

25
crates/oxc_linter/src/rules/eslint/no_unused_vars/mod.rs
View file

@ -11,7 +11,7 @@ mod usage;
use std::ops::Deref; use std::ops::Deref;
use options::NoUnusedVarsOptions; use options::{IgnorePattern, NoUnusedVarsOptions};
use oxc_ast::AstKind; use oxc_ast::AstKind;
use oxc_macros::declare_oxc_lint; use oxc_macros::declare_oxc_lint;
use oxc_semantic::{AstNode, ScopeFlags, SymbolFlags, SymbolId}; use oxc_semantic::{AstNode, ScopeFlags, SymbolFlags, SymbolId};
@ -238,7 +238,7 @@ impl NoUnusedVars {
match (is_used, is_ignored) { match (is_used, is_ignored) {
(true, true) => { (true, true) => {
if self.report_used_ignore_pattern { if self.report_used_ignore_pattern {
ctx.diagnostic(diagnostic::used_ignored(symbol)); ctx.diagnostic(diagnostic::used_ignored(symbol, &self.vars_ignore_pattern));
} }
return; return;
}, },
@ -283,9 +283,9 @@ impl NoUnusedVars {
if let Some(last_write) = symbol.references().rev().find(|r| r.is_write()) { if let Some(last_write) = symbol.references().rev().find(|r| r.is_write()) {
// ahg // ahg
let span = ctx.nodes().get_node(last_write.node_id()).kind().span(); let span = ctx.nodes().get_node(last_write.node_id()).kind().span();
diagnostic::assign(symbol, span) diagnostic::assign(symbol, span, &self.vars_ignore_pattern)
} else { } else {
diagnostic::declared(symbol) diagnostic::declared(symbol, &self.vars_ignore_pattern)
}; };
ctx.diagnostic_with_suggestion(report, |fixer| { ctx.diagnostic_with_suggestion(report, |fixer| {
@ -298,39 +298,42 @@ impl NoUnusedVars {
if self.is_allowed_argument(ctx.semantic().as_ref(), symbol, param) { if self.is_allowed_argument(ctx.semantic().as_ref(), symbol, param) {
return; return;
} }
ctx.diagnostic(diagnostic::param(symbol)); ctx.diagnostic(diagnostic::param(symbol, &self.args_ignore_pattern));
} }
AstKind::BindingRestElement(_) => { AstKind::BindingRestElement(_) => {
if NoUnusedVars::is_allowed_binding_rest_element(symbol) { if NoUnusedVars::is_allowed_binding_rest_element(symbol) {
return; return;
} }
ctx.diagnostic(diagnostic::declared(symbol)); ctx.diagnostic(diagnostic::declared(symbol, &self.vars_ignore_pattern));
} }
AstKind::Class(_) | AstKind::Function(_) => { AstKind::Class(_) | AstKind::Function(_) => {
if self.is_allowed_class_or_function(symbol) { if self.is_allowed_class_or_function(symbol) {
return; return;
} }
ctx.diagnostic(diagnostic::declared(symbol)); ctx.diagnostic(diagnostic::declared(symbol, &IgnorePattern::<&str>::None));
} }
AstKind::TSModuleDeclaration(namespace) => { AstKind::TSModuleDeclaration(namespace) => {
if self.is_allowed_ts_namespace(symbol, namespace) { if self.is_allowed_ts_namespace(symbol, namespace) {
return; return;
} }
ctx.diagnostic(diagnostic::declared(symbol)); ctx.diagnostic(diagnostic::declared(symbol, &IgnorePattern::<&str>::None));
} }
AstKind::TSInterfaceDeclaration(_) => { AstKind::TSInterfaceDeclaration(_) => {
if symbol.is_in_declared_module() { if symbol.is_in_declared_module() {
return; return;
} }
ctx.diagnostic(diagnostic::declared(symbol)); ctx.diagnostic(diagnostic::declared(symbol, &IgnorePattern::<&str>::None));
} }
AstKind::TSTypeParameter(_) => { AstKind::TSTypeParameter(_) => {
if self.is_allowed_type_parameter(symbol, declaration.id()) { if self.is_allowed_type_parameter(symbol, declaration.id()) {
return; return;
} }
ctx.diagnostic(diagnostic::declared(symbol)); ctx.diagnostic(diagnostic::declared(symbol, &self.vars_ignore_pattern));
} }
_ => ctx.diagnostic(diagnostic::declared(symbol)), AstKind::CatchParameter(_) => {
ctx.diagnostic(diagnostic::declared(symbol, &self.caught_errors_ignore_pattern));
}
_ => ctx.diagnostic(diagnostic::declared(symbol, &IgnorePattern::<&str>::None)),
}; };
} }

16
crates/oxc_linter/src/rules/eslint/no_unused_vars/options.rs
View file

@ -271,6 +271,22 @@ impl<R> IgnorePattern<R> {
} }
} }
} }
impl<R> IgnorePattern<R>
where
R: std::fmt::Display,
{
pub(super) fn diagnostic_help(&self, symbol_kind_plural: &str) -> Cow<'static, str> {
match self {
Self::None => Cow::Borrowed(""),
Self::Default => {
Cow::Owned(format!(" Unused {symbol_kind_plural} should start with a '_'."))
}
Self::Some(reg) => {
Cow::Owned(format!(" Unused {symbol_kind_plural} should match /{reg}/."))
}
}
}
}
impl From<Option<Regex>> for IgnorePattern<Regex> { impl From<Option<Regex>> for IgnorePattern<Regex> {
#[inline] #[inline]

274
crates/oxc_linter/src/snapshots/no_unused_vars@eslint.snap
View file

File diff suppressed because it is too large Load diff

4
crates/oxc_linter/src/snapshots/no_unused_vars@oxc-arguments.snap
View file

@ -1,7 +1,7 @@
--- ---
source: crates/oxc_linter/src/tester.rs source: crates/oxc_linter/src/tester.rs
--- ---
⚠ eslint(no-unused-vars): Parameter 'a' is declared but never used. ⚠ eslint(no-unused-vars): Parameter 'a' is declared but never used. Unused parameters should start with a '_'.
╭─[no_unused_vars.tsx:1:14] ╭─[no_unused_vars.tsx:1:14]
1 │ function foo(a) {} foo() 1 │ function foo(a) {} foo()
· ┬ · ┬
@ -9,7 +9,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Consider removing this parameter. help: Consider removing this parameter.
⚠ eslint(no-unused-vars): Parameter 'a' is declared but never used. ⚠ eslint(no-unused-vars): Parameter 'a' is declared but never used. Unused parameters should start with a '_'.
╭─[no_unused_vars.tsx:1:14] ╭─[no_unused_vars.tsx:1:14]
1 │ function foo(a: number) {} foo() 1 │ function foo(a: number) {} foo()
· ┬ · ┬

6
crates/oxc_linter/src/snapshots/no_unused_vars@oxc-classes.snap
View file

@ -1,7 +1,7 @@
--- ---
source: crates/oxc_linter/src/tester.rs source: crates/oxc_linter/src/tester.rs
--- ---
⚠ eslint(no-unused-vars): Parameter 'a' is declared but never used. ⚠ eslint(no-unused-vars): Parameter 'a' is declared but never used. Unused parameters should start with a '_'.
╭─[no_unused_vars.tsx:1:32] ╭─[no_unused_vars.tsx:1:32]
1 │ export class Foo { constructor(a: number) {} } 1 │ export class Foo { constructor(a: number) {} }
· ┬ · ┬
@ -9,7 +9,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Consider removing this parameter. help: Consider removing this parameter.
⚠ eslint(no-unused-vars): Parameter 'value' is declared but never used. ⚠ eslint(no-unused-vars): Parameter 'value' is declared but never used. Unused parameters should start with a '_'.
╭─[no_unused_vars.tsx:1:24] ╭─[no_unused_vars.tsx:1:24]
1 │ export class Foo { set(value) { } } 1 │ export class Foo { set(value) { } }
· ──┬── · ──┬──
@ -17,7 +17,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Consider removing this parameter. help: Consider removing this parameter.
⚠ eslint(no-unused-vars): Parameter 'a' is declared but never used. ⚠ eslint(no-unused-vars): Parameter 'a' is declared but never used. Unused parameters should start with a '_'.
╭─[no_unused_vars.tsx:3:24] ╭─[no_unused_vars.tsx:3:24]
2 │ export abstract class Foo { 2 │ export abstract class Foo {
3 │ public bar(a: number): string {} 3 │ public bar(a: number): string {}

4
crates/oxc_linter/src/snapshots/no_unused_vars@oxc-functions.snap
View file

@ -26,7 +26,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Consider removing this declaration. help: Consider removing this declaration.
⚠ eslint(no-unused-vars): Variable 'interpolations' is declared but never used. ⚠ eslint(no-unused-vars): Variable 'interpolations' is declared but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:3:46] ╭─[no_unused_vars.tsx:3:46]
2 │ export function log(message: string, ...interpolations: unknown[]): void; 2 │ export function log(message: string, ...interpolations: unknown[]): void;
3 │ export function log(message: string, ...interpolations: unknown[]): void { 3 │ export function log(message: string, ...interpolations: unknown[]): void {
@ -36,7 +36,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Consider removing this declaration. help: Consider removing this declaration.
⚠ eslint(no-unused-vars): Variable 'messages' is declared but never used. ⚠ eslint(no-unused-vars): Variable 'messages' is declared but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:2:29] ╭─[no_unused_vars.tsx:2:29]
1 │ 1 │
2 │ export function log(...messages: unknown[]): void { 2 │ export function log(...messages: unknown[]): void {

2
crates/oxc_linter/src/snapshots/no_unused_vars@oxc-type-aliases.snap
View file

@ -25,7 +25,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Consider removing this declaration. help: Consider removing this declaration.
⚠ eslint(no-unused-vars): Variable 'R' is declared but never used. ⚠ eslint(no-unused-vars): Variable 'R' is declared but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:36] ╭─[no_unused_vars.tsx:1:36]
1 │ export type F<T> = T extends infer R ? /* R not used */ string : never 1 │ export type F<T> = T extends infer R ? /* R not used */ string : never
· ┬ · ┬

8
crates/oxc_linter/src/snapshots/no_unused_vars@oxc-vars-catch.snap
View file

@ -1,7 +1,7 @@
--- ---
source: crates/oxc_linter/src/tester.rs source: crates/oxc_linter/src/tester.rs
--- ---
⚠ eslint(no-unused-vars): Variable 'e' is caught but never used. ⚠ eslint(no-unused-vars): Catch parameter 'e' is caught but never used.
╭─[no_unused_vars.tsx:1:15] ╭─[no_unused_vars.tsx:1:15]
1 │ try {} catch (e) { } 1 │ try {} catch (e) { }
· ┬ · ┬
@ -9,7 +9,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Consider handling this error. help: Consider handling this error.
⚠ eslint(no-unused-vars): Variable '_' is caught but never used. ⚠ eslint(no-unused-vars): Catch parameter '_' is caught but never used.
╭─[no_unused_vars.tsx:1:14] ╭─[no_unused_vars.tsx:1:14]
1 │ try {} catch(_) { } 1 │ try {} catch(_) { }
· ┬ · ┬
@ -17,7 +17,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Consider handling this error. help: Consider handling this error.
⚠ eslint(no-unused-vars): Variable '_' is caught but never used. ⚠ eslint(no-unused-vars): Catch parameter '_' is caught but never used.
╭─[no_unused_vars.tsx:1:14] ╭─[no_unused_vars.tsx:1:14]
1 │ try {} catch(_) { } 1 │ try {} catch(_) { }
· ┬ · ┬
@ -25,7 +25,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Consider handling this error. help: Consider handling this error.
⚠ eslint(no-unused-vars): Variable 'foo' is caught but never used. ⚠ eslint(no-unused-vars): Catch parameter 'foo' is caught but never used. Unused caught errors should match /^ignored/.
╭─[no_unused_vars.tsx:1:14] ╭─[no_unused_vars.tsx:1:14]
1 │ try {} catch(foo) { } 1 │ try {} catch(foo) { }
· ─┬─ · ─┬─

4
crates/oxc_linter/src/snapshots/no_unused_vars@oxc-vars-destructure.snap
View file

@ -49,7 +49,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Consider removing this declaration. help: Consider removing this declaration.
⚠ eslint(no-unused-vars): Variable 'l' is declared but never used. ⚠ eslint(no-unused-vars): Variable 'l' is declared but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:7] ╭─[no_unused_vars.tsx:1:7]
1 │ const l="",{e}=r 1 │ const l="",{e}=r
· ┬ · ┬
@ -57,7 +57,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Consider removing this declaration. help: Consider removing this declaration.
⚠ eslint(no-unused-vars): Variable 'e' is declared but never used. ⚠ eslint(no-unused-vars): Variable 'e' is declared but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:13] ╭─[no_unused_vars.tsx:1:13]
1 │ const l="",{e}=r 1 │ const l="",{e}=r
· ┬ · ┬

4
crates/oxc_linter/src/snapshots/no_unused_vars@oxc-vars-discarded-read.snap
View file

@ -1,7 +1,7 @@
--- ---
source: crates/oxc_linter/src/tester.rs source: crates/oxc_linter/src/tester.rs
--- ---
⚠ eslint(no-unused-vars): Parameter 'a' is declared but never used. ⚠ eslint(no-unused-vars): Parameter 'a' is declared but never used. Unused parameters should start with a '_'.
╭─[no_unused_vars.tsx:2:22] ╭─[no_unused_vars.tsx:2:22]
1 │ 1 │
2 │ function foo(a) { return (a, 0); } 2 │ function foo(a) { return (a, 0); }
@ -11,7 +11,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Consider removing this parameter. help: Consider removing this parameter.
⚠ eslint(no-unused-vars): Variable 'I' is declared but never used. ⚠ eslint(no-unused-vars): Variable 'I' is declared but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:2:15] ╭─[no_unused_vars.tsx:2:15]
1 │ 1 │
2 │ const I = (e) => (l) => { 2 │ const I = (e) => (l) => {

22
crates/oxc_linter/src/snapshots/no_unused_vars@oxc-vars-reassignment.snap
View file

@ -1,7 +1,7 @@
--- ---
source: crates/oxc_linter/src/tester.rs source: crates/oxc_linter/src/tester.rs
--- ---
⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. ⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:5] ╭─[no_unused_vars.tsx:1:5]
1 │ let a = 1; a ||= 2; 1 │ let a = 1; a ||= 2;
· ┬ ┬ · ┬ ┬
@ -10,7 +10,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Did you mean to use this variable? help: Did you mean to use this variable?
⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. ⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:5] ╭─[no_unused_vars.tsx:1:5]
1 │ let a = 0; a = a + 1; 1 │ let a = 0; a = a + 1;
· ┬ ┬ · ┬ ┬
@ -19,7 +19,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Did you mean to use this variable? help: Did you mean to use this variable?
⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. ⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:5] ╭─[no_unused_vars.tsx:1:5]
1 │ let a = 0; a = a++ as any; 1 │ let a = 0; a = a++ as any;
· ┬ ┬ · ┬ ┬
@ -28,7 +28,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Did you mean to use this variable? help: Did you mean to use this variable?
⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. ⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:5] ╭─[no_unused_vars.tsx:1:5]
1 │ let a = 0; a = a as unknown as string as unknown as number; 1 │ let a = 0; a = a as unknown as string as unknown as number;
· ┬ ┬ · ┬ ┬
@ -37,7 +37,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Did you mean to use this variable? help: Did you mean to use this variable?
⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. ⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:5] ╭─[no_unused_vars.tsx:1:5]
1 │ let a = 0; a = ++a; 1 │ let a = 0; a = ++a;
· ┬ ┬ · ┬ ┬
@ -46,7 +46,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Did you mean to use this variable? help: Did you mean to use this variable?
⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. ⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:5] ╭─[no_unused_vars.tsx:1:5]
1 │ let a = 0; a = (0, ++a); 1 │ let a = 0; a = (0, ++a);
· ┬ ┬ · ┬ ┬
@ -55,7 +55,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Did you mean to use this variable? help: Did you mean to use this variable?
⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. ⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:5] ╭─[no_unused_vars.tsx:1:5]
1 │ let a = 0; a = (a++, 0); 1 │ let a = 0; a = (a++, 0);
· ┬ ┬ · ┬ ┬
@ -64,7 +64,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Did you mean to use this variable? help: Did you mean to use this variable?
⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. ⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:5] ╭─[no_unused_vars.tsx:1:5]
1 │ let a = 0; let b = (a++, 0); f(b); 1 │ let a = 0; let b = (a++, 0); f(b);
· ┬ ┬ · ┬ ┬
@ -73,7 +73,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Did you mean to use this variable? help: Did you mean to use this variable?
⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. ⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:5] ╭─[no_unused_vars.tsx:1:5]
1 │ let a = 0; let b = (0, (a++, 0)); f(b); 1 │ let a = 0; let b = (0, (a++, 0)); f(b);
· ┬ ┬ · ┬ ┬
@ -82,7 +82,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Did you mean to use this variable? help: Did you mean to use this variable?
⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. ⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:5] ╭─[no_unused_vars.tsx:1:5]
1 │ let a = 0; let b = ((0, a++), 0); f(b); 1 │ let a = 0; let b = ((0, a++), 0); f(b);
· ┬ ┬ · ┬ ┬
@ -91,7 +91,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Did you mean to use this variable? help: Did you mean to use this variable?
⚠ eslint(no-unused-vars): Variable 'a' is declared but never used. ⚠ eslint(no-unused-vars): Variable 'a' is declared but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:5] ╭─[no_unused_vars.tsx:1:5]
1 │ let a = 0; let b = (a, 0) + 1; f(b); 1 │ let a = 0; let b = (a, 0) + 1; f(b);
· ┬ · ┬

2
crates/oxc_linter/src/snapshots/no_unused_vars@oxc-vars-self-use.snap
View file

@ -11,7 +11,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Consider removing this declaration. help: Consider removing this declaration.
⚠ eslint(no-unused-vars): Variable 'foo' is declared but never used. ⚠ eslint(no-unused-vars): Variable 'foo' is declared but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:2:15] ╭─[no_unused_vars.tsx:2:15]
1 │ 1 │
2 │ const foo = () => { 2 │ const foo = () => {

10
crates/oxc_linter/src/snapshots/no_unused_vars@oxc-vars-simple.snap
View file

@ -1,7 +1,7 @@
--- ---
source: crates/oxc_linter/src/tester.rs source: crates/oxc_linter/src/tester.rs
--- ---
⚠ eslint(no-unused-vars): Variable 'a' is declared but never used. ⚠ eslint(no-unused-vars): Variable 'a' is declared but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:5] ╭─[no_unused_vars.tsx:1:5]
1 │ let a = 1 1 │ let a = 1
· ┬ · ┬
@ -9,7 +9,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Consider removing this declaration. help: Consider removing this declaration.
⚠ eslint(no-unused-vars): Variable 'a' is declared but never used. ⚠ eslint(no-unused-vars): Variable 'a' is declared but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:5] ╭─[no_unused_vars.tsx:1:5]
1 │ let a: number = 1 1 │ let a: number = 1
· ┬ · ┬
@ -17,7 +17,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Consider removing this declaration. help: Consider removing this declaration.
⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. ⚠ eslint(no-unused-vars): Variable 'a' is assigned a value but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:5] ╭─[no_unused_vars.tsx:1:5]
1 │ let a = 1; a = 2 1 │ let a = 1; a = 2
· ┬ ┬ · ┬ ┬
@ -32,9 +32,9 @@ source: crates/oxc_linter/src/tester.rs
· ─┬ · ─┬
· ╰── '_a' is declared here · ╰── '_a' is declared here
╰──── ╰────
help: Consider renaming this variable. help: Consider renaming this variable to match the pattern /^_/.
⚠ eslint(no-unused-vars): Variable 'fooBar' is declared but never used. ⚠ eslint(no-unused-vars): Variable 'fooBar' is declared but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:14] ╭─[no_unused_vars.tsx:1:14]
1 │ const { foo: fooBar, baz } = obj; f(baz); 1 │ const { foo: fooBar, baz } = obj; f(baz);
· ───┬── · ───┬──

2
crates/oxc_linter/src/snapshots/no_unused_vars@oxc-vars-using.snap
View file

@ -1,7 +1,7 @@
--- ---
source: crates/oxc_linter/src/tester.rs source: crates/oxc_linter/src/tester.rs
--- ---
⚠ eslint(no-unused-vars): Variable 'a' is declared but never used. ⚠ eslint(no-unused-vars): Variable 'a' is declared but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.tsx:1:7] ╭─[no_unused_vars.tsx:1:7]
1 │ using a = 1; 1 │ using a = 1;
· ┬ · ┬

6
crates/oxc_linter/src/snapshots/no_unused_vars@typescript-eslint.snap
View file

@ -272,7 +272,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Consider removing this declaration. help: Consider removing this declaration.
⚠ eslint(no-unused-vars): Variable 'x' is declared but never used. ⚠ eslint(no-unused-vars): Variable 'x' is declared but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.ts:7:31] ╭─[no_unused_vars.ts:7:31]
6 │ namespace Bam { 6 │ namespace Bam {
7 │ const x = 1; 7 │ const x = 1;
@ -292,7 +292,7 @@ source: crates/oxc_linter/src/tester.rs
╰──── ╰────
help: Consider removing this declaration. help: Consider removing this declaration.
⚠ eslint(no-unused-vars): Variable 'foo' is assigned a value but never used. ⚠ eslint(no-unused-vars): Variable 'foo' is assigned a value but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.ts:2:15] ╭─[no_unused_vars.ts:2:15]
1 │ 1 │
2 │ let foo = 1; 2 │ let foo = 1;
@ -333,7 +333,7 @@ source: crates/oxc_linter/src/tester.rs
8 │ 8 │
╰──── ╰────
⚠ eslint(no-unused-vars): Variable 'foo' is declared but never used. ⚠ eslint(no-unused-vars): Variable 'foo' is declared but never used. Unused variables should start with a '_'.
╭─[no_unused_vars.ts:1:7] ╭─[no_unused_vars.ts:1:7]
1 │ const foo: number = 1; 1 │ const foo: number = 1;
· ─┬─ · ─┬─