From 0fa0c25fb3e2758282c151a378ab82d64a025445 Mon Sep 17 00:00:00 2001 From: JT <547158+jntrnr@users.noreply.github.com> Date: Fri, 10 Sep 2021 13:13:11 +1200 Subject: [PATCH] Fix clippy warnings (#3997) --- crates/nu-command/src/commands/filters/each/command.rs | 4 ++-- crates/nu-command/src/commands/filters/each/group.rs | 6 +++--- crates/nu-command/src/commands/filters/each/window.rs | 2 +- crates/nu-command/src/commands/filters/group_by.rs | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/crates/nu-command/src/commands/filters/each/command.rs b/crates/nu-command/src/commands/filters/each/command.rs index 03616830..c3782233 100644 --- a/crates/nu-command/src/commands/filters/each/command.rs +++ b/crates/nu-command/src/commands/filters/each/command.rs @@ -69,7 +69,7 @@ impl WholeStreamCommand for Each { } pub fn process_row( - captured_block: Arc>, + captured_block: Arc, context: Arc, input: Value, external_redirection: ExternalRedirection, @@ -121,7 +121,7 @@ fn each(args: CommandArgs) -> Result { let block: CapturedBlock = args.req(0)?; let numbered: bool = args.has_flag("numbered"); - let block = Arc::new(Box::new(block)); + let block = Arc::new(block); if numbered { Ok(args diff --git a/crates/nu-command/src/commands/filters/each/group.rs b/crates/nu-command/src/commands/filters/each/group.rs index ebf5a4b0..2d82b3f9 100644 --- a/crates/nu-command/src/commands/filters/each/group.rs +++ b/crates/nu-command/src/commands/filters/each/group.rs @@ -43,7 +43,7 @@ impl WholeStreamCommand for EachGroup { let group_size: Tagged = args.req(0)?; let block: CapturedBlock = args.req(1)?; - let block = Arc::new(Box::new(block)); + let block = Arc::new(block); let each_group_iterator = EachGroupIterator { block, @@ -58,7 +58,7 @@ impl WholeStreamCommand for EachGroup { } struct EachGroupIterator { - block: Arc>, + block: Arc, context: Arc, group_size: usize, input: InputStream, @@ -96,7 +96,7 @@ impl Iterator for EachGroupIterator { pub(crate) fn run_block_on_vec( input: Vec, - block: Arc>, + block: Arc, context: Arc, external_redirection: ExternalRedirection, ) -> OutputStream { diff --git a/crates/nu-command/src/commands/filters/each/window.rs b/crates/nu-command/src/commands/filters/each/window.rs index 2b7efbd5..e5d85571 100644 --- a/crates/nu-command/src/commands/filters/each/window.rs +++ b/crates/nu-command/src/commands/filters/each/window.rs @@ -49,7 +49,7 @@ impl WholeStreamCommand for EachWindow { let block: CapturedBlock = args.req(1)?; let stride: Option> = args.get_flag("stride")?; - let block = Arc::new(Box::new(block)); + let block = Arc::new(block); let mut window: Vec<_> = args .input diff --git a/crates/nu-command/src/commands/filters/group_by.rs b/crates/nu-command/src/commands/filters/group_by.rs index cd9841b4..c764d7b0 100644 --- a/crates/nu-command/src/commands/filters/group_by.rs +++ b/crates/nu-command/src/commands/filters/group_by.rs @@ -137,7 +137,7 @@ pub fn group_by(args: CommandArgs) -> Result { value: UntaggedValue::Block(block_given), .. }) => { - let block = Arc::new(block_given); + let block = Arc::new(*block_given); let error_key = "error"; for value in &values {