dan/node-x11
1
0
Fork 0
mirror of https://github.com/danbulant/node-x11 synced 2026-05-24 12:35:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Receive xrandr & dpms exts correctly in tests

Browse source 
This makes tests pass that were failing with null reference errors.

`XClient.require` was passing the callback function to `requireExt`,
which called it with parameters `null, ext` on success. The callback
itself seemed to assume it will get only one parameter, which is either
the extension on an error, hence why it tried to call methods on a
`null`.
This commit is contained in:
An Ko 2014-11-03 15:52:34 +01:00
parent def55ef359
commit c67043f1ed
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
test-runner.js
View file

@ -15,8 +15,8 @@ var mocha = new Mocha({
// 2 - dpms version is 1.1. // 2 - dpms version is 1.1.
// 3 - to be dpms capable. // 3 - to be dpms capable.
var run_dpms_test = function(X, cb) { var run_dpms_test = function(X, cb) {
X.require('dpms', function(ext) { X.require('dpms', function(err, ext) {
if (!util.isError(ext)) { if (!util.isError(err)) {
dpms = ext; dpms = ext;
dpms.GetVersion(undefined, undefined, function(err, version) { dpms.GetVersion(undefined, undefined, function(err, version) {
if (!err && version[0] === 1 && version[1] === 1) { if (!err && version[0] === 1 && version[1] === 1) {
@ -42,8 +42,8 @@ var run_xtest_test = function(X, cb) {
}; };
var run_randr_test = function(X, cb) { var run_randr_test = function(X, cb) {
X.require('randr', function(ext) { X.require('randr', function(err, ext) {
if (!util.isError(ext)) { if (!util.isError(err)) {
randr = ext; randr = ext;
randr.QueryVersion(1, 2, function(err, version) { randr.QueryVersion(1, 2, function(err, version) {
if (err) { if (err) {