From 2df9069ef119f07013401fa7eeb46899744fe73a Mon Sep 17 00:00:00 2001 From: Santiago Gimeno Date: Tue, 24 Jul 2012 09:57:48 +0200 Subject: [PATCH] Declare some more undeclared variables So they don't pollute the global object. --- lib/x11/corereqs.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/x11/corereqs.js b/lib/x11/corereqs.js index a3cdefc..8b5a221 100644 --- a/lib/x11/corereqs.js +++ b/lib/x11/corereqs.js @@ -84,7 +84,7 @@ function packValueMask(reqname, values) var args = []; for (m in masksList) { - valueName = reqValueMaskName[masksList[m]]; + var valueName = reqValueMaskName[masksList[m]]; args.push( values[valueName] ); } return [bitmask, args] @@ -162,7 +162,7 @@ module.exports = { // add values in the order of the bits // TODO: maybe it's better just to scan all 32 bits anstead of sorting parameters we are actually have? - for (m in masksList) + for (var m in masksList) { var valueName = valueMaskName['CreateWindow'][masksList[m]]; args.push( values[valueName] ); @@ -179,7 +179,7 @@ module.exports = { var vals = packValueMask('CreateWindow', values); var args = [2, packetLength, wid, vals[0]]; var valArr = vals[1]; - for (v in valArr) + for (var v in valArr) { format += 'L'; args.push(valArr[v]); @@ -439,7 +439,7 @@ module.exports = { var vals = packValueMask('CreateGC', values); args.push(vals[0]); // values bitmask var valArr = vals[1]; - for (v in valArr) + for (var v in valArr) { format += 'L'; // TODO: we know format string length in advance and += inefficient for string args.push(valArr[v]); @@ -456,7 +456,7 @@ module.exports = { var vals = packValueMask('CreateGC', values); args.push(vals[0]); // values bitmask var valArr = vals[1]; - for (v in valArr) + for (var v in valArr) { format += 'L'; // TODO: we know format string length in advance and += inefficient for string args.push(valArr[v]);