dan/node-html-parser
1
0
Fork 0
mirror of https://github.com/danbulant/node-html-parser synced 2026-06-20 07:01:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

🐛 fix Issue #17

Browse source
This commit is contained in:
taoqf 2020-02-05 14:13:04 +08:00
parent a777a8814f
commit 92ea19ac9f
2 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/nodes/html.ts
View file

@ -445,15 +445,18 @@ export default class HTMLElement extends Node {
* @param {string|number} value The value to set, or null / undefined to remove an attribute * @param {string|number} value The value to set, or null / undefined to remove an attribute
*/ */
setAttribute(key: string, value: string | number) { setAttribute(key: string, value: string | number) {
// Invalidate current this.attributes
if (this._attrs) {
delete this._attrs;
}
const attrs = this.rawAttributes; const attrs = this.rawAttributes;
if (value === undefined || value === null) { if (value === undefined || value === null) {
delete attrs[key]; delete attrs[key];
// Update this.attribute
if (this._attrs && this._attrs[key]) {
delete this._attrs[key];
}
} else { } else {
attrs[key] = String(value); attrs[key] = String(value);
if (this._attrs) {
this._attrs[key] = decode(attrs[key]);
}
} }
// Update rawString // Update rawString
this.rawAttrs = Object.keys(attrs).map((name) => { this.rawAttrs = Object.keys(attrs).map((name) => {

4
test/html.js
View file

@ -334,10 +334,12 @@ describe('HTML Parser', function () {
describe('#setAttribute', function () { describe('#setAttribute', function () {
it('should edit the attributes of the element', function () { it('should edit the attributes of the element', function () {
var root = parseHTML('<p a=12></p>'); var root = parseHTML('<p a=12></p>');
var attr = root.firstChild.attributes;
root.firstChild.setAttribute('a', 13); root.firstChild.setAttribute('a', 13);
root.firstChild.attributes.should.eql({ attr.should.eql({
'a': '13', 'a': '13',
}); });
root.firstChild.getAttribute('a').should.eql('13');
root.firstChild.toString().should.eql('<p a="13"></p>'); root.firstChild.toString().should.eql('<p a="13"></p>');
}); });
it('should add an attribute to the element', function () { it('should add an attribute to the element', function () {