From 3a873e083c36891d18cef81deb9ac81946658b79 Mon Sep 17 00:00:00 2001 From: Remco Haszing Date: Sat, 20 Nov 2021 12:20:23 +0100 Subject: [PATCH] Add support for document symbol details This is set to the raw value for primitives by the YAML language service. The demo now uses this value as the title attribute on the breadcrumbs. Closes #137 --- examples/demo/src/index.ts | 1 + src/languageFeatures.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/demo/src/index.ts b/examples/demo/src/index.ts index 48e73e1..e79dc46 100644 --- a/examples/demo/src/index.ts +++ b/examples/demo/src/index.ts @@ -184,6 +184,7 @@ ed.onDidChangeCursorPosition(async (event) => { breadcrumb.setAttribute('role', 'button'); breadcrumb.classList.add('breadcrumb'); breadcrumb.textContent = symbol.name; + breadcrumb.title = symbol.detail; if (symbol.kind === languages.SymbolKind.Array) { breadcrumb.classList.add('array'); } else if (symbol.kind === languages.SymbolKind.Module) { diff --git a/src/languageFeatures.ts b/src/languageFeatures.ts index 02bd875..3622230 100644 --- a/src/languageFeatures.ts +++ b/src/languageFeatures.ts @@ -341,7 +341,7 @@ function toSymbolKind(kind: ls.SymbolKind): languages.SymbolKind { function toDocumentSymbol(item: ls.DocumentSymbol): languages.DocumentSymbol { return { - detail: '', + detail: item.detail || '', range: toRange(item.range), name: item.name, kind: toSymbolKind(item.kind),