dan/gpui-component
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

input: Fix set_value when Input is disabled. (#1362)

Browse source 
Close #1350
This commit is contained in:
Jason Lee 2025-10-13 11:15:32 +08:00 committed by GitHub
parent 08cf199b39
commit 97df4efd46
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
crates/story/src/input_story.rs
View file

@ -1,6 +1,6 @@
use gpui::{ use gpui::{
div, App, AppContext as _, Context, Entity, InteractiveElement, IntoElement, App, AppContext as _, Context, Entity, InteractiveElement, IntoElement, ParentElement as _,
ParentElement as _, Render, Styled, Subscription, Window, Render, Styled, Subscription, Window, div,
}; };
use crate::section; use crate::section;
@ -121,13 +121,20 @@ impl InputStory {
&mut self, &mut self,
state: &Entity<InputState>, state: &Entity<InputState>,
event: &InputEvent, event: &InputEvent,
_window: &mut Window, window: &mut Window,
_cx: &mut Context<Self>, cx: &mut Context<Self>,
) { ) {
match event { match event {
InputEvent::Change => { InputEvent::Change => {
let text = state.read(_cx).value(); let text = state.read(cx).value();
println!("Change: {}", text) if state == &self.input2 {
println!("Set disabled value: {}", text);
self.disabled_input.update(cx, |this, cx| {
this.set_value(text, window, cx);
})
} else {
println!("Change: {}", text)
}
} }
InputEvent::PressEnter { secondary } => println!("PressEnter secondary: {}", secondary), InputEvent::PressEnter { secondary } => println!("PressEnter secondary: {}", secondary),
InputEvent::Focus => println!("Focus"), InputEvent::Focus => println!("Focus"),

1
crates/ui/src/input/state.rs
View file

@ -637,6 +637,7 @@ impl InputState {
) { ) {
self.history.ignore = true; self.history.ignore = true;
let was_disabled = self.disabled; let was_disabled = self.disabled;
self.disabled = false;
self.replace_text(value, window, cx); self.replace_text(value, window, cx);
self.disabled = was_disabled; self.disabled = was_disabled;
self.history.ignore = false; self.history.ignore = false;