dan/gpui-component
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

text_view: Use weak references to the state in async task to avoid memory leaks. (#1311)

Browse source
This commit is contained in:
Sunli 2025-09-30 15:26:59 +08:00 committed by GitHub
parent 880c019fb8
commit 591cfc8dab
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 14 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
crates/ui/src/text/text_view.rs
View file

@ -518,17 +518,22 @@ impl Element for TextView {
}); });
cx.spawn({ cx.spawn({
let state = self.state.clone(); let state = self.state.downgrade();
async move |cx| { async move |cx| {
while let Ok(parsed_result) = rx_result.recv().await { while let Ok(parsed_result) = rx_result.recv().await {
_ = state.update(cx, |state, cx| { if let Some(state) = state.upgrade() {
state.parsed_result = Some(parsed_result); _ = state.update(cx, |state, cx| {
if let Some(parent_entity) = state.parent_entity { state.parsed_result = Some(parsed_result);
let app = &mut **cx; if let Some(parent_entity) = state.parent_entity {
app.notify(parent_entity); let app = &mut **cx;
} app.notify(parent_entity);
state.clear_selection(); }
}); state.clear_selection();
});
} else {
// state released, stopping processing
break;
}
} }
} }
}) })