dan/gpui-component
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

virtual_list: Fix VirtualList to limit only allow 1 direction scrollable. (#1386)

Browse source 
It should only allow to scroll in one direction.

For example, when `axis` is `vertical`, the horizontal should not able
to scroll.
This commit is contained in:
Jason Lee 2025-10-16 14:25:13 +08:00 committed by GitHub
parent 43a2c814a3
commit 4341cf81d3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
crates/ui/src/virtual_list.rs
View file

@ -18,11 +18,11 @@ use std::{
};
use gpui::{
div, point, px, size, Along, AnyElement, App, AvailableSpace, Axis, Bounds, ContentMask,
Context, DeferredScrollToItem, Div, Element, ElementId, Entity, GlobalElementId, Half, Hitbox,
InteractiveElement, IntoElement, IsZero as _, ListSizingBehavior, Pixels, Point, Render,
ScrollHandle, ScrollStrategy, Size, Stateful, StatefulInteractiveElement, StyleRefinement,
Styled, Window,
div, point, prelude::FluentBuilder as _, px, size, Along, AnyElement, App, AvailableSpace,
Axis, Bounds, ContentMask, Context, DeferredScrollToItem, Div, Element, ElementId, Entity,
GlobalElementId, Half, Hitbox, InteractiveElement, IntoElement, IsZero as _,
ListSizingBehavior, Pixels, Point, Render, ScrollHandle, ScrollStrategy, Size, Stateful,
StatefulInteractiveElement, StyleRefinement, Styled, Window,
};
use smallvec::SmallVec;
@ -181,7 +181,10 @@ where
base: div()
.id(id)
.size_full()
.overflow_scroll()
.map(|this| match axis {
Axis::Horizontal => this.overflow_x_scroll().overflow_y_hidden(),
Axis::Vertical => this.overflow_y_scroll().overflow_x_hidden(),
})
.track_scroll(&scroll_handle),
scroll_handle,
items_count: item_sizes.len(),