dan/gpui-component
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert "dock: Change bottom dock to floating on bottom of the center view." (#420)

Browse source 
Reverts longbridgeapp/gpui-component#419
This commit is contained in:
Jason Lee 2024-11-14 19:01:57 +08:00 committed by GitHub
parent a2d6752557
commit 3db84c1247
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
crates/ui/src/dock/mod.rs
View file

@ -49,8 +49,6 @@ pub struct DockArea {
left_dock: Option<View<Dock>>, left_dock: Option<View<Dock>>,
/// The bottom dock of the dockarea. /// The bottom dock of the dockarea.
bottom_dock: Option<View<Dock>>, bottom_dock: Option<View<Dock>>,
/// If true, the bottom dock is floating on bottom of the center view.
float_bottom_dock: bool,
/// The right dock of the dockarea. /// The right dock of the dockarea.
right_dock: Option<View<Dock>>, right_dock: Option<View<Dock>>,
/// The top zoom view of the dockarea, if any. /// The top zoom view of the dockarea, if any.
@ -244,7 +242,6 @@ impl DockArea {
right_dock: None, right_dock: None,
bottom_dock: None, bottom_dock: None,
is_locked: false, is_locked: false,
float_bottom_dock: true,
_subscriptions: vec![], _subscriptions: vec![],
}; };
@ -541,7 +538,6 @@ impl Render for DockArea {
// Center // Center
.child( .child(
div() div()
.relative()
.flex() .flex()
.flex_1() .flex_1()
.flex_col() .flex_col()
@ -555,18 +551,7 @@ impl Render for DockArea {
) )
// Bottom Dock // Bottom Dock
.when_some(self.bottom_dock.clone(), |this, dock| { .when_some(self.bottom_dock.clone(), |this, dock| {
if self.float_bottom_dock { this.child(dock)
this.child(
div()
.absolute()
.left_0()
.right_0()
.bottom_0()
.child(dock),
)
} else {
this
}
}), }),
) )
// Right Dock // Right Dock