dan/gpui-component
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

number_input: Fix NumberInput appearance by #858 change. (#860)

Browse source
This commit is contained in:
Jason Lee 2025-05-17 10:51:04 +08:00 committed by GitHub
parent bc398adbf3
commit 3c85ccbe2a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
crates/ui/src/input/number_input.rs
View file

@ -1,6 +1,6 @@
use gpui::{ use gpui::{
actions, prelude::FluentBuilder as _, px, App, Context, Entity, EventEmitter, FocusHandle, actions, prelude::FluentBuilder as _, px, App, Context, ElementId, Entity, EventEmitter,
Focusable, InteractiveElement, IntoElement, KeyBinding, ParentElement, RenderOnce, FocusHandle, Focusable, InteractiveElement, IntoElement, KeyBinding, ParentElement, RenderOnce,
SharedString, Styled, Window, SharedString, Styled, Window,
}; };
@ -26,6 +26,7 @@ pub fn init(cx: &mut App) {
#[derive(IntoElement)] #[derive(IntoElement)]
pub struct NumberInput { pub struct NumberInput {
id: ElementId,
state: Entity<InputState>, state: Entity<InputState>,
placeholder: SharedString, placeholder: SharedString,
size: Size, size: Size,
@ -35,6 +36,7 @@ impl NumberInput {
/// Create a new [`NumberInput`] element bind to the [`InputState`]. /// Create a new [`NumberInput`] element bind to the [`InputState`].
pub fn new(state: &Entity<InputState>) -> Self { pub fn new(state: &Entity<InputState>) -> Self {
Self { Self {
id: ("number-input", state.entity_id()).into(),
state: state.clone(), state: state.clone(),
size: Size::default(), size: Size::default(),
placeholder: SharedString::default(), placeholder: SharedString::default(),
@ -115,6 +117,7 @@ impl RenderOnce for NumberInput {
}; };
h_flex() h_flex()
.id(self.id)
.key_context(KEY_CONTENT) .key_context(KEY_CONTENT)
.on_action(window.listener_for(&self.state, InputState::on_action_increment)) .on_action(window.listener_for(&self.state, InputState::on_action_increment))
.on_action(window.listener_for(&self.state, InputState::on_action_decrement)) .on_action(window.listener_for(&self.state, InputState::on_action_decrement))
@ -142,7 +145,7 @@ impl RenderOnce for NumberInput {
} }
}), }),
) )
.child(TextInput::new(&self.state).no_gap()) .child(TextInput::new(&self.state).appearance(false).no_gap())
.child( .child(
Button::new("plus") Button::new("plus")
.ghost() .ghost()