dan/gpui-component
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: Fix dialog scroll by #1694 change. (#1695)

Browse source
This commit is contained in:
Jason Lee 2025-11-27 21:11:20 +08:00 committed by GitHub
parent 118a0f500e
commit 36b229068d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
crates/story/src/dialog_story.rs
View file

@ -359,7 +359,8 @@ impl Render for DialogStory {
.on_click(cx.listener(move |_, _, window, cx| {
window.open_dialog(cx, move |dialog, window, cx| {
dialog
.h(px(450.))
.w(px(720.))
.h(px(600.))
.overlay(dialog_overlay)
.overlay_closable(overlay_closable)
.title("Dialog with scrollbar")

12
crates/ui/src/dialog.rs
View file

@ -1,7 +1,7 @@
use std::{rc::Rc, time::Duration};
use gpui::{
Animation, AnimationExt as _, AnyElement, App, Bounds, BoxShadow, ClickEvent, Div, Edges,
Animation, AnimationExt as _, AnyElement, App, Bounds, BoxShadow, ClickEvent, Div, Edges,
FocusHandle, Hsla, InteractiveElement, IntoElement, KeyBinding, MouseButton, ParentElement,
Pixels, Point, RenderOnce, SharedString, StyleRefinement, Styled, Window, anchored, div, hsla,
point, prelude::FluentBuilder, px, relative,
@ -231,6 +231,14 @@ impl Dialog {
self
}
/// Sets the width of the dialog, defaults to 480px.
///
/// See also [`Self::width`]
pub fn w(mut self, width: Pixels) -> Self {
self.width = width;
self
}
/// Sets the width of the dialog, defaults to 480px.
pub fn width(mut self, width: Pixels) -> Self {
self.width = width;
@ -502,7 +510,7 @@ impl RenderOnce for Dialog {
.id("contents")
.pl(paddings.left)
.pr(paddings.right)
.overflow_scrollbar()
.overflow_y_scrollbar()
.child(self.content),
),
)