dan/gpui-component
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

table: Revert deferred render scrollbr for table. (#542)

Browse source 
This will make scrollbar always stay on top, even there have other
element cover it.
This commit is contained in:
Jason Lee 2025-01-12 22:32:43 +08:00 committed by GitHub
parent 464fceac96
commit 205a499bc9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
crates/ui/src/table.rs
View file

@ -11,8 +11,8 @@ use crate::{
Icon, IconName, Sizable, Size, StyleSized as _, Icon, IconName, Sizable, Size, StyleSized as _,
}; };
use gpui::{ use gpui::{
actions, canvas, deferred, div, prelude::FluentBuilder, px, uniform_list, AppContext, Axis, actions, canvas, div, prelude::FluentBuilder, px, uniform_list, AppContext, Axis, Bounds, Div,
Bounds, Div, DragMoveEvent, Edges, Entity, EntityId, EventEmitter, FocusHandle, FocusableView, DragMoveEvent, Edges, Entity, EntityId, EventEmitter, FocusHandle, FocusableView,
InteractiveElement, IntoElement, KeyBinding, ListSizingBehavior, MouseButton, MouseDownEvent, InteractiveElement, IntoElement, KeyBinding, ListSizingBehavior, MouseButton, MouseDownEvent,
ParentElement, Pixels, Point, Render, ScrollHandle, ScrollStrategy, SharedString, Stateful, ParentElement, Pixels, Point, Render, ScrollHandle, ScrollStrategy, SharedString, Stateful,
StatefulInteractiveElement as _, Styled, UniformListScrollHandle, ViewContext, StatefulInteractiveElement as _, Styled, UniformListScrollHandle, ViewContext,
@ -1279,19 +1279,14 @@ where
|_, _, _| {}, |_, _, _| {},
)) ))
.child( .child(
// use deferred to render the scrollbar for div()
// avoid some custom element overflow the scrollbar. .absolute()
deferred( .top_0()
div() .size_full()
.absolute() .child(self.render_horizontal_scrollbar(cx))
.top_0() .when(rows_count > 0, |this| {
.size_full() this.children(self.render_scrollbar(cx))
.child(self.render_horizontal_scrollbar(cx)) }),
.when(rows_count > 0, |this| {
this.children(self.render_scrollbar(cx))
}),
)
.with_priority(0),
) )
// Click out to cancel right clicked row // Click out to cancel right clicked row
.when(self.right_clicked_row.is_some(), |this| { .when(self.right_clicked_row.is_some(), |this| {