From e33b4fad58089cd98fcad5fcaa384d1e7585b73e Mon Sep 17 00:00:00 2001
From: end-4 <97237370+end-4@users.noreply.github.com>
Date: Mon, 19 May 2025 09:00:21 +0200
Subject: [PATCH] dont open media controls when empty

---
 .config/quickshell/modules/mediaControls/MediaControls.qml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/.config/quickshell/modules/mediaControls/MediaControls.qml b/.config/quickshell/modules/mediaControls/MediaControls.qml
index c5b3b87a..20495611 100644
--- a/.config/quickshell/modules/mediaControls/MediaControls.qml
+++ b/.config/quickshell/modules/mediaControls/MediaControls.qml
@@ -19,6 +19,7 @@ Scope {
     required property var bar
     property bool visible: false
     readonly property MprisPlayer activePlayer: MprisController.activePlayer
+    readonly property var realPlayers: Mpris.players.values.filter(player => isRealPlayer(player))
     readonly property real osdWidth: Appearance.sizes.osdWidth
     readonly property real widgetWidth: Appearance.sizes.mediaControlsWidth
     readonly property real widgetHeight: Appearance.sizes.mediaControlsHeight
@@ -83,7 +84,7 @@ Scope {
 
                 Repeater {
                     model: ScriptModel {
-                        values: Mpris.players.values.filter(player => isRealPlayer(player))
+                        values: root.realPlayers
                     }
                     delegate: PlayerControl {
                         required property MprisPlayer modelData
@@ -117,6 +118,9 @@ Scope {
         description: "Toggles media controls on press"
 
         onPressed: {
+            if (!mediaControlsLoader.active && Mpris.players.values.filter(player => isRealPlayer(player)).length === 0) {
+                return;
+            }
             mediaControlsLoader.active = !mediaControlsLoader.active;
             if(mediaControlsLoader.active) Notifications.timeoutAll();
         }