dan/discord.js
1
0
Fork 0
mirror of https://github.com/danbulant/discord.js synced 2026-06-07 08:41:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

UnhandledPromiseRejectionWarning caused by resolveBuffer on empty resource body (#886)

Browse source 
* Fix for UnhandledPromiseRejectionWarning in resolveBuffer

* code simplification

* reject with TypeError if body is not a Buffer
This commit is contained in:
Steffen 2016-11-13 08:07:51 +01:00 committed by Schuyler Cebulskie
parent c041b1bc23
commit a359f344d8
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/client/ClientDataResolver.js
View file

@ -244,7 +244,11 @@ class ClientDataResolver {
if (/^https?:\/\//.test(resource)) { if (/^https?:\/\//.test(resource)) {
request.get(resource) request.get(resource)
.set('Content-Type', 'blob') .set('Content-Type', 'blob')
.end((err, res) => err ? reject(err) : resolve(res.body)); .end((err, res) => {
if (err) return reject(err);
if (!(res.body instanceof Buffer)) return reject(new TypeError('Body is not a Buffer'));
return resolve(res.body);
});
} else { } else {
const file = path.resolve(resource); const file = path.resolve(resource);
fs.stat(file, (err, stats) => { fs.stat(file, (err, stats) => {