dan/discord.js
1
0
Fork 0
mirror of https://github.com/danbulant/discord.js synced 2026-07-08 12:40:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert "Cache array and keyArray in Collection (#771)"

Browse source 
This reverts commit 53f5c2cb52.
This commit is contained in:
Schuyler Cebulskie 2016-10-22 15:11:42 -04:00
parent 8308493618
commit 562b62a5b6
1 changed files with 4 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/util/Collection.js
View file

@ -3,16 +3,6 @@
* @extends {Map} * @extends {Map}
*/ */
class Collection extends Map { class Collection extends Map {
set(key, value) {
super.set(key, value);
this.changed = true;
}
delete(key) {
super.delete(key);
this.changed = true;
}
/** /**
* Returns an ordered array of the values of this collection. * Returns an ordered array of the values of this collection.
* @returns {Array} * @returns {Array}
@ -77,11 +67,8 @@ class Collection extends Map {
* @returns {*} * @returns {*}
*/ */
random() { random() {
if (!this.cachedArray || this.cachedArray.length !== this.size || this.changed) { const arr = this.array();
this.cachedArray = this.array(); return arr[Math.floor(Math.random() * arr.length)];
this.changed = false;
}
return this.cachedArray[Math.floor(Math.random() * this.cachedArray.length)];
} }
/** /**
@ -90,11 +77,8 @@ class Collection extends Map {
* @returns {*} * @returns {*}
*/ */
randomKey() { randomKey() {
if (!this.cachedKeyArray || this.cachedKeyArray.length !== this.size || this.changed) { const arr = this.keyArray();
this.cachedKeyArray = this.keyArray(); return arr[Math.floor(Math.random() * arr.length)];
this.changed = false;
}
return this.cachedKeyArray[Math.floor(Math.random() * this.cachedKeyArray.length)];
} }
/** /**