dan/discord.js
1
0
Fork 0
mirror of https://github.com/danbulant/discord.js synced 2026-07-05 11:10:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

GuildEmoji.fetchAuthor() error handling (#2788)

Browse source 
* handle when client has insufficient permissions, add typing

* code review
This commit is contained in:
lipgloss 2018-08-31 20:52:50 -06:00 committed by Crawl
parent be4d6f9dc3
commit 314161ab70
3 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/errors/Messages.js
View file

@ -95,6 +95,8 @@ const Messages = {
EMOJI_TYPE: 'Emoji must be a string or GuildEmoji/ReactionEmoji', EMOJI_TYPE: 'Emoji must be a string or GuildEmoji/ReactionEmoji',
EMOJI_MANAGED: 'Emoji is managed and has no Author.', EMOJI_MANAGED: 'Emoji is managed and has no Author.',
MISSING_MANAGE_EMOJIS_PERMISSION:
guild => `Client must have Manage Emoji permission in guild ${guild} to see emoji authors.`,
REACTION_RESOLVE_USER: 'Couldn\'t resolve the user ID to remove from the reaction.', REACTION_RESOLVE_USER: 'Couldn\'t resolve the user ID to remove from the reaction.',

2
src/structures/GuildEmoji.js
View file

@ -90,6 +90,8 @@ class GuildEmoji extends Emoji {
fetchAuthor() { fetchAuthor() {
if (this.managed) { if (this.managed) {
return Promise.reject(new Error('EMOJI_MANAGED')); return Promise.reject(new Error('EMOJI_MANAGED'));
} else if (!this.guild.me.permissions.has(Permissions.FLAGS.MANAGE_EMOJIS)) {
return Promise.reject(new Error('MISSING_MANAGE_EMOJIS_PERMISSION', this.guild));
} }
return this.client.api.guilds(this.guild.id).emojis(this.id).get() return this.client.api.guilds(this.guild.id).emojis(this.id).get()
.then(emoji => this.client.users.add(emoji.user)); .then(emoji => this.client.users.add(emoji.user));

1
typings/index.d.ts vendored
View file

@ -545,6 +545,7 @@ declare module 'discord.js' {
public delete(reason?: string): Promise<GuildEmoji>; public delete(reason?: string): Promise<GuildEmoji>;
public edit(data: GuildEmojiEditData, reason?: string): Promise<GuildEmoji>; public edit(data: GuildEmojiEditData, reason?: string): Promise<GuildEmoji>;
public equals(other: GuildEmoji | object): boolean; public equals(other: GuildEmoji | object): boolean;
public fetchAuthor(): Promise<User>;
public setName(name: string, reason?: string): Promise<GuildEmoji>; public setName(name: string, reason?: string): Promise<GuildEmoji>;
} }