dan/Portfolio
1
0
Fork 0
mirror of https://github.com/danbulant/Portfolio synced 2026-07-05 19:11:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: get_details endpoint

Browse source
This commit is contained in:
Sebastian Pravda 2022-11-27 11:05:00 +01:00
parent 02303d4b31
commit 44f036a4c4
No known key found for this signature in database
GPG key ID: F3BC84F08EFA3F57
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
api/src/routes/candidate.rs
View file

@ -82,13 +82,13 @@ pub async fn add_details(
conn: Connection<'_, Db>, conn: Connection<'_, Db>,
details: Json<ApplicationDetails>, details: Json<ApplicationDetails>,
session: CandidateAuth, session: CandidateAuth,
) -> Result<String, Custom<String>> { ) -> Result<Json<ApplicationDetails>, Custom<String>> {
let db = conn.into_inner(); let db = conn.into_inner();
let form = details.into_inner(); let form = details.into_inner();
let candidate: entity::candidate::Model = session.into(); // TODO: don't return candidate from session let candidate: entity::candidate::Model = session.into(); // TODO: don't return candidate from session
let candidate_parent = let candidate_parent =
ApplicationService::add_all_details(db, candidate.application, form).await; ApplicationService::add_all_details(db, candidate.application, &form).await;
if candidate_parent.is_err() { if candidate_parent.is_err() {
// TODO cleanup // TODO cleanup
@ -99,10 +99,12 @@ pub async fn add_details(
)); ));
} }
Ok("Details added".to_string()) Ok(
Json(form)
)
} }
#[post("/get_details")] #[get("/details")]
pub async fn get_details( pub async fn get_details(
conn: Connection<'_, Db>, conn: Connection<'_, Db>,
session: CandidateAuth, session: CandidateAuth,
@ -404,7 +406,7 @@ mod tests {
assert_eq!(response.status(), Status::Ok); assert_eq!(response.status(), Status::Ok);
let response = client let response = client
.post("/candidate/get_details") .get("/candidate/details")
.cookie(cookies.0) .cookie(cookies.0)
.cookie(cookies.1) .cookie(cookies.1)
.dispatch(); .dispatch();
@ -433,7 +435,7 @@ mod tests {
assert_eq!(response.status(), Status::Unauthorized); assert_eq!(response.status(), Status::Unauthorized);
let response = client let response = client
.post("/candidate/get_details") .get("/candidate/details")
.cookie(id.clone()) .cookie(id.clone())
.cookie(key.clone()) .cookie(key.clone())
.dispatch(); .dispatch();
@ -461,7 +463,7 @@ mod tests {
assert_eq!(response.status(), Status::Unauthorized); assert_eq!(response.status(), Status::Unauthorized);
let response = client let response = client
.post("/candidate/get_details") .get("/candidate/details")
.cookie(cookies.0.clone()) .cookie(cookies.0.clone())
.cookie(cookies.1.clone()) .cookie(cookies.1.clone())
.dispatch(); .dispatch();