dan/Portfolio
1
0
Fork 0
mirror of https://github.com/danbulant/Portfolio synced 2026-06-06 16:20:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: remove event dispatcher from grade table, bottom margin

Browse source
This commit is contained in:
EETagent 2023-01-17 00:04:29 +01:00
parent 3233945dd4
commit 28ed1cea88
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
frontend/src/lib/components/grades/GradesTable.svelte
View file

@ -7,11 +7,9 @@
</script> </script>
<script lang="ts"> <script lang="ts">
import { createEventDispatcher } from 'svelte';
import GradesRow, { type Grade, type Semester } from './GradesRow.svelte'; import GradesRow, { type Grade, type Semester } from './GradesRow.svelte';
let gradesLocal: Array<Grade> = Array.from({ length: 1 }, () => { let gradesLocal: Array<Grade> = Array.from({ length: 8 }, () => {
return { return {
subject: '', subject: '',
semesters: { semesters: {
@ -27,8 +25,6 @@
export let grades: Array<GradeBackend>; export let grades: Array<GradeBackend>;
const dispatch = createEventDispatcher();
// Convert local Grade type to expanded GradesBackend type // Convert local Grade type to expanded GradesBackend type
const convertGrades = () => { const convertGrades = () => {
// Delay to wait for select to be updated // Delay to wait for select to be updated
@ -49,7 +45,6 @@
} }
} }
grades = [...gradesTemp]; grades = [...gradesTemp];
dispatch('change', grades);
}); });
}; };
</script> </script>
@ -63,7 +58,9 @@
<span class="ml-0.5 w-1/6 text-center">2/9</span> <span class="ml-0.5 w-1/6 text-center">2/9</span>
</div> </div>
{#each gradesLocal as _, i} {#each gradesLocal as _, i}
<GradesRow on:keyup={convertGrades} on:change={convertGrades} bind:grade={gradesLocal[i]} /> <div class="mb-1">
<GradesRow on:keyup={convertGrades} on:change={convertGrades} bind:grade={gradesLocal[i]} />
</div>
{/each} {/each}
<button <button
class:isError={error.length > 0} class:isError={error.length > 0}