More from Gendarme. Cosmos.VS.Package's AssemblyVersion attribute didn't match it's AssemblyFileVersion, they now match. Sealed a few non-inherited attributes. Also made private field actually used as was intended.

This commit is contained in:
blah38621_cp 2011-10-23 00:15:19 +00:00
parent 8f1d4c09fb
commit dcd685a90f
7 changed files with 15 additions and 8 deletions

View file

@ -41,7 +41,7 @@ namespace Cosmos.Build.Common {
public enum TraceAssemblies { All, Cosmos, User }; public enum TraceAssemblies { All, Cosmos, User };
public enum DebugMode { None, IL, Source } public enum DebugMode { None, IL, Source }
public class DescriptionAttribute : Attribute { public sealed class DescriptionAttribute : Attribute {
public static String GetDescription(object value) { public static String GetDescription(object value) {
Type valueType = value.GetType(); Type valueType = value.GetType();
MemberInfo[] valueMemberInfo; MemberInfo[] valueMemberInfo;

View file

@ -5,7 +5,7 @@ using System.Text;
namespace Cosmos.Compiler.Assembler namespace Cosmos.Compiler.Assembler
{ {
public class OpCodeAttribute: Attribute public sealed class OpCodeAttribute: Attribute
{ {
public OpCodeAttribute(string mnemonic) public OpCodeAttribute(string mnemonic)
{ {

View file

@ -6,7 +6,7 @@ using System.Text;
namespace Cosmos.Compiler.XSharp { namespace Cosmos.Compiler.XSharp {
[AttributeUsage(AttributeTargets.Method, AllowMultiple = false, Inherited = false)] [AttributeUsage(AttributeTargets.Method, AllowMultiple = false, Inherited = false)]
public class XSharpAttribute : Attribute { public sealed class XSharpAttribute : Attribute {
public bool IsInteruptHandler { get; set; } public bool IsInteruptHandler { get; set; }
public bool PreserveStack { get; set; } public bool PreserveStack { get; set; }
} }

View file

@ -7,7 +7,14 @@ namespace Cosmos.IL2CPU.Plugs
private string mName; private string mName;
public string Name public string Name
{ {
get; set; get
{
return mName;
}
set
{
mName = value;
}
} }
} }
} }

View file

@ -6,7 +6,7 @@ using System.Text;
namespace Cosmos.IL2CPU namespace Cosmos.IL2CPU
{ {
[AttributeUsage(AttributeTargets.Class, Inherited = true, AllowMultiple = true)] [AttributeUsage(AttributeTargets.Class, Inherited = true, AllowMultiple = true)]
public class OpCodeAttribute : Attribute public sealed class OpCodeAttribute : Attribute
{ {
public ILOpCode.Code OpCode public ILOpCode.Code OpCode
{ {

View file

@ -5,7 +5,7 @@ using System.Text;
namespace Cosmos.Core { namespace Cosmos.Core {
[AttributeUsageAttribute(AttributeTargets.Class, AllowMultiple=true)] [AttributeUsageAttribute(AttributeTargets.Class, AllowMultiple=true)]
public class DeviceIDAttribute : Attribute { public sealed class DeviceIDAttribute : Attribute {
public UInt16 VendorID; public UInt16 VendorID;
public UInt16 DeviceID; public UInt16 DeviceID;
} }

View file

@ -29,9 +29,9 @@ using System.Runtime.InteropServices;
// You can specify all the values or you can default the Revision and Build Numbers // You can specify all the values or you can default the Revision and Build Numbers
// by using the '*' as shown below: // by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
// Note: AssemblyVersion MUST match whats in the PLK. AssemblyFileVersion can be anything though. // Note: AssemblyVersion MUST match what is in the PLK. AssemblyFileVersion can be anything though.
[assembly: AssemblyVersion("1.0.0.0")] [assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.1")] [assembly: AssemblyFileVersion("1.0.0.0")]